Skip to content

Add --skipLibCheck compiler option #8735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahejlsberg wants to merge 2 commits into from
Closed

Add --skipLibCheck compiler option #8735

ahejlsberg wants to merge 2 commits into from

Conversation

@ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented May 22, 2016 •
edited
Loading

This PR adds a new --skipLibCheck compiler option that causes type checking of declaration files (files with extension .d.ts) to be skipped. When a program includes large declaration files, the compiler spends a lot of time type checking declarations that are already known to not contain errors, and compile times may be significantly shortened by skipping declaration file type checks.

Since declarations in one file can affect type checking in other files, some errors may not be detected when --skipLibCheck is specified. For example, if a non-declaration file augments a type declared in a declaration file, errors may result that are only reported when the declaration file is checked. However, in practice such situations are rare.

Fixes #8521. Compile times for the example given in this issue are reduced 5x.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 22, 2016

👍

2 similar comments
@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2016

👍

@vladima
Copy link
Contributor

vladima commented May 23, 2016

👍

@ahejlsberg ahejlsberg closed this May 23, 2016
@ahejlsberg ahejlsberg deleted the skipLibCheck branch May 23, 2016 18:02
@johnnyreilly johnnyreilly mentioned this pull request May 30, 2016
Closed
@christopherthielen christopherthielen mentioned this pull request Jun 24, 2016
Closed
@mhegazy mhegazy mentioned this pull request Jun 30, 2016
Closed
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 7, 2016
Closed
17 tasks
@saschanaz saschanaz mentioned this pull request Jul 26, 2016
Closed
basarat
basarat reviewed Jul 27, 2016
View reviewed changes
src/compiler/checker.ts
}
/ If skipLibCheck is enabled, skip type checking if file is a declaration file.
/ If skipDefaultLibCheck is enabled, skip type checking if file contains a
/ '/ <reference no-default-lib="true"/>' directive.
Copy link
Contributor

@basarat basarat Jul 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we would skip for noDefaultLib. Is this to support just test harnesses or actual user code? 🌹

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ahejlsberg @DanielRosenwasser @mhegazy @vladima @basarat @msftclas

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant