Skip to content

ENH: non-nano datetime64s for read_sas #56127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 13 commits into from
Dec 5, 2023
Merged

ENH: non-nano datetime64s for read_sas #56127

mroeschke merged 13 commits into from
Dec 5, 2023

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 23, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Pre-empts a bunch of the remaining test failures in #55901.

cc @ChadFulton for help determing what the correct "expected"s should be.

@mroeschke mroeschke added IO SAS SAS: read_sas Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Nov 26, 2023
mroeschke
mroeschke reviewed Nov 30, 2023
View reviewed changes
doc/source/whatsnew/v2.2.0.rst Outdated
- :meth:`to_sql` with method parameter set to ``multi`` works with Oracle on the backend
- :attr:`Series.attrs` / :attr:`DataFrame.attrs` now uses a deepcopy for propagating ``attrs`` (:issue:`54134`).
- :func:`read_csv` now supports ``on_bad_lines`` parameter with ``engine="pyarrow"``. (:issue:`54480`)
- :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be help with ``datetime64[ns]`` dtype (:issue:`56127`)
Copy link
Member

@mroeschke mroeschke Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be help with ``datetime64[ns]`` dtype (:issue:`56127`)
- :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be stored with ``datetime64[ns]`` dtype (:issue:`56127`)

?

mroeschke
mroeschke reviewed Nov 30, 2023
View reviewed changes
pandas/io/sas/sas7bdat.py
)


_unix_origin = Timestamp("1970-01-01")
Copy link
Member

@mroeschke mroeschke Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be reused in the future? Otherwise could just inline the 10 year timedelta in _convert_datetimes

Copy link
Member Author

@jbrockmendel jbrockmendel Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way. i think this is nicely clear about where the 10 year difference stems from (also cant do Timedelta(years=10))

@mroeschke mroeschke added this to the 2.2 milestone Dec 5, 2023
@mroeschke mroeschke merged commit 33ff3d9 into pandas-dev:main Dec 5, 2023
@mroeschke
Copy link
Member

mroeschke commented Dec 5, 2023

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-sas branch December 5, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

Assignees

No one assigned

Labels

IO SAS SAS: read_sas Non-Nano datetime64/timedelta64 with non-nanosecond resolution

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @mroeschke

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant