We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a small regression that was introduced with #51090 (in pandas 2.0): before that PR, the column subselection in the groupby code was done with a standard __getitem__ call, while the PR introduced an optimized helper _getitem_nocopy to avoid the copy that a standard __getitem__ does. However, that new helper forgot to add a __finalize__ call after _constructor from a manager.
__getitem__
_getitem_nocopy
__finalize__
_constructor
The reason we noticed this in geopandas (geopandas/geopandas#3130) was to update our tests for the apply deprecation to include group columns (for which one alternative is to specifically select the non-group columns, but so that didn't work with recent pandas versions)
apply
Sorry, something went wrong.
BUG: fix subclass metadata preservation in groupby column selection
8da1d39
add whatsnew
7234621
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
lgtm
99db9af
thx @jorisvandenbossche
Backport PR pandas-dev#56761: BUG: fix subclass metadata preservation…
0f16a48
… in groupby column selection
#56761 on branch 2.2.x (BUG: fix subclass metadata preser…
57079b6
…vation in groupby column selection) (#56770) Backport PR #56761: BUG: fix subclass metadata preservation in groupby column selection Co-authored-by: Joris Van den Bossche <[email protected]>
BUG: fix subclass metadata preservation in groupby column selection (p…
d49adf3
…andas-dev#56761)
rhshadrach rhshadrach approved these changes
phofl phofl approved these changes
Successfully merging this pull request may close these issues.