Skip to content

Re-enable skipped test_zlib tests on s390x hardware acceleration #125041

Closed
@encukou

Description

@encukou

Some variants of the s390x platform have instructions for hardware-accelerated deflate compression. With HW acceleration, compressed byte stream can be different from the software implementation in zlib. (It still decompresses to the original of course.)
The zlib-ng library can be built to use this, and CPython can be built with zlib-ng.

In 2022 (#90781, GH-31096), two tests that failed on s390x were unconditionally skipped. IMO, it would be better if we only skip checking the compressed stream, but do check the round-trip result.
Testing should be a bit easier now that a buildbot worker has the HW-accelerated zlib.

In #107535, the skip_on_s390x variable was separated from the comment that explains it.
I propose to name the skip condition HW_ACCELERATED rather than skip_on_s390x -- theoretically, other platforms might need this in the future.

Linked PRs

Activity

self-assigned this
on Oct 7, 2024
added a commit that references this issue on Oct 7, 2024

pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…

added a commit that references this issue on Oct 15, 2024

gh-125041: test_zlib: For s390x HW acceleration, only skip checking t…

cc5a225
added a commit that references this issue on Oct 15, 2024

pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…

added 2 commits that reference this issue on Oct 16, 2024

[3.13] gh-125041: test_zlib: For s390x HW acceleration, only skip che…

e3ae564

pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…

added a commit that references this issue on Oct 16, 2024

pythongh-125041: pythongh-90781: test_zlib: For s390x HW acceleration…

11 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

pendingThe issue will be closed if no feedback is providedtestsTests in the Lib/test dir

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Re-enable skipped test_zlib tests on s390x hardware acceleration · Issue #125041 · python/cpython

    Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

    Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant