Skip to content

Increase test coverage for HMAC #132388

Closed
Closed
@picnixz

Description

@picnixz

Feature or enhancement

Proposal:

After implementing HACL* HMAC in #99108, I've observed that I didn't test all code paths and that some tests I assumed were a bit incorrect (some redundancy was done). This is an issue to track all improvements done to HMAC tests (I'm planning to target an almost 100% coverage), but I'll close it when nothing needs to be done "for now".

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Activity

added
stdlibPython modules in the Lib dir
testsTests in the Lib/test dir
type-featureA feature request or enhancement
on Apr 11, 2025
self-assigned this
on Apr 11, 2025
added a commit that references this issue on Apr 12, 2025

gh-132388: Increase test coverage for HMAC (#132389)

9634085
added a commit that references this issue on Apr 13, 2025

gh-132388: fix typos in `Lib/test/test_hmac.py` (#132480)

a1cd4ca
added a commit that references this issue on Apr 26, 2025

gh-132388: remove outdated TODO comment in `test_hmac.py` (#133008)

e714ead
added a commit that references this issue on May 16, 2025

gh-132388: test HACL* and OpenSSL hash functions in pure Python HMAC (#…

73d71a4
added a commit that references this issue on May 16, 2025

pythongh-132388: test HACL* and OpenSSL hash functions in pure Python…

2 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirstdlibPython modules in the Lib dirtestsTests in the Lib/test dirtype-featureA feature request or enhancement

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Increase test coverage for HMAC · Issue #132388 · python/cpython

    Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

    Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant