Skip to content

Tools/build/compute-changes.py looks at the wrong branches #133410

Closed
@JelleZijlstra

Description

@JelleZijlstra

Bug report

Bug description:

Tools/build/compute-changes.py assumes that both of the branches being compared are on the origin origin. This is usually not going to be the case for PR branches. If the PR branch happens to be called main, this can lead to no tests being run, as happened on #131419.

cc @AA-Turner

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

added
infraCI, GitHub Actions, buildbots, Dependabot, etc.
type-bugAn unexpected behavior, bug, or error
on May 4, 2025
self-assigned this
on May 5, 2025
added a commit that references this issue on May 5, 2025

GH-133410: Use commit hashes for change detection (gh-133416)

d530e74
changed the title [-]`Tools/build/compute_changes.py` looks at the wrong branches[/-] [+]`Tools/build/compute-changes.py` looks at the wrong branches[/+] on May 5, 2025
added a commit that references this issue on May 5, 2025

pythonGH-133410: Use commit hashes for change detection (pythongh-133416

added a commit that references this issue on May 5, 2025

[3.13] GH-133410: Use commit hashes for change detection (gh-133416) (#…

1105ed3
added a commit that references this issue on May 5, 2025

[3.12] GH-133410: Use commit hashes for change detection (gh-133416) (#…

483729f
added a commit that references this issue on May 8, 2025

Revert "pythonGH-133410: Use commit hashes for change detection (pyth…

hugovk

hugovk commented on May 8, 2025

@hugovk
Member
No description provided.

16 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.type-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    `Tools/build/compute-changes.py` looks at the wrong branches · Issue #133410 · python/cpython

    Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

    Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant