`Python/instrumentation.c`: ensure non-NULL `PyLong_FromLong` results when possible

[smurav]

cpython/Python/instrumentation.c

Line 2566 in c740fe3

Py_DECREF(val);

Since PyLong_FromLong can return NULL, it is necessary to use Py_XDECREF, as stated in refcount.h.

cpython/Include/refcount.h

Line 207 in c740fe3

NULL pointer. If it may be NULL, use Py_XINCREF/Py_XDECREF instead.

Linked PRs

• gh-134411: assert PyLong_FromLong(x) != NULL when x is known to be small #134415

[sergey-miryanov]

It falls to small_int case and can't return NULL. I suggest adding an assert and leave the decref code as is.

[smurav]

Yes, I think it's the right thing to do.

[skv0zsneg]

Hi! I want to work on this issue but I didn't work with CPython at all. If it not a problem can you please provide some links for start?

[grantlouisherman]

I think this can be closed because of #134415 right?

[picnixz]

It'll be closed once we merged the PR.