socket.inet_aton returns 8 bytes on LP64 platforms

[mwichmann]

BPO	1008086
Nosy	@Yhg1s, @gpshead, @mwichmann, @amauryfa, @pitrou, @devdanzin
Files	socketmod.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2009-11-01.20:30:04.581>
created_at = <Date 2004-08-12.16:50:09.000>
labels = ['extension-modules', 'easy', 'type-bug']
title = 'socket.inet_aton returns 8 bytes on LP64 platforms'
updated_at = <Date 2009-11-01.20:30:04.580>
user = 'https://github.com/mwichmann'

bugs.python.org fields:

activity = <Date 2009-11-01.20:30:04.580>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2009-11-01.20:30:04.581>
closer = 'gregory.p.smith'
components = ['Extension Modules']
creation = <Date 2004-08-12.16:50:09.000>
creator = 'mwichmann'
dependencies = []
files = ['6180']
hgrepos = []
issue_num = 1008086
keywords = ['64bit', 'easy']
message_count = 10.0
messages = ['46687', '46688', '81520', '81522', '81523', '81687', '81688', '81691', '90272', '94803']
nosy_count = 7.0
nosy_names = ['twouters', 'collinwinter', 'gregory.p.smith', 'mwichmann', 'amaury.forgeotdarc', 'pitrou', 'ajaksu2']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1008086'
versions = ['Python 2.6', 'Python 3.0']

[mwichmann]

The attached is a fix for the same problem that is
reported in 767150. For 2.3.x and head cvs this
problem exists in the code path taken if configure does
not detect inet_aton. I have not checked this against
2.2, which is the platform 767150 reports it against,
there may be header inclusion issues that make it not
work there but the essence is that the quantity worked
with has to be forced to be a 32-bit quanitity, not
declared unsigned long.

[collinwinter]

The patch is only one line, changing a unsigned long to in_addr_t. Could someone familiar with/with access to Linux on an IA64 machine take a look at this?

Thomas, I notice a lot of posts from you about 64-bit issues... ; )

[devdanzin]

This is a patch for bpo-767150, which was closed in 2005.

[pitrou]

I'm not sure in_addr_t is available everywhere. "unsigned int" should be
a good bet, since it is 32-bits in most platforms. Guarding the code
with a "#if (SIZEOF_INT == 4)" and erroring out otherwise will make the
patch ok (and, please add a test).

[pitrou]

Sorry, reopening.

[gpshead]

fixing now.