Code, test, and doc review for PEP-0435 Enum

[ethanfurman]

BPO	17947
Nosy	@gvanrossum, @warsaw, @ncoghlan, @vstinner, @benjaminp, @ezio-melotti, @alex, @ethanfurman, @zware, @phmc, @dstufft
Files	pep-0435.01.patch pep-0435.02.patch pep-0435.03.patch pep-0435.04.patch pep-0435.05.patch pep-0435.06.patch: latest code with appropriate changes pep-0435.07.eliben.patch pep-0435.09.stoneleaf.patch pep-0435.10.stoneleaf.patch pep-0435.11.stoneleaf.patch pep-0435.12.stoneleaf.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ethanfurman'
closed_at = <Date 2013-06-14.23:56:10.900>
created_at = <Date 2013-05-10.06:50:00.848>
labels = ['tests', 'type-feature', 'library', 'docs']
title = 'Code, test, and doc review for PEP-0435 Enum'
updated_at = <Date 2013-06-15.00:57:57.086>
user = 'https://github.com/ethanfurman'

bugs.python.org fields:

activity = <Date 2013-06-15.00:57:57.086>
actor = 'ncoghlan'
assignee = 'ethan.furman'
closed = True
closed_date = <Date 2013-06-14.23:56:10.900>
closer = 'python-dev'
components = ['Documentation', 'Library (Lib)', 'Tests']
creation = <Date 2013-05-10.06:50:00.848>
creator = 'ethan.furman'
dependencies = []
files = ['30192', '30195', '30202', '30209', '30231', '30265', '30384', '30506', '30511', '30512', '30548']
hgrepos = []
issue_num = 17947
keywords = ['patch']
message_count = 65.0
messages = ['188812', '188814', '188815', '188833', '188837', '188839', '188841', '188856', '188881', '188891', '188893', '188894', '188895', '188921', '188933', '188941', '188947', '188948', '188975', '188977', '188979', '188982', '189014', '189020', '189021', '189027', '189029', '189036', '189160', '189164', '189175', '189188', '189263', '189446', '190033', '190095', '190099', '190115', '190118', '190119', '190122', '190123', '190126', '190130', '190131', '190312', '190795', '190796', '190803', '190804', '190805', '190806', '190842', '190844', '190847', '190862', '190870', '190980', '191103', '191104', '191133', '191137', '191172', '191173', '191181']
nosy_count = 15.0
nosy_names = ['gvanrossum', 'barry', 'ncoghlan', 'vstinner', 'benjamin.peterson', 'ezio.melotti', 'alex', 'eli.bendersky', 'docs@python', 'ethan.furman', 'python-dev', 'zach.ware', 'pconnell', 'dstufft', 'isoschiz']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17947'
versions = ['Python 3.4']

[ethanfurman]

PEP-0435 has been approved!

Now for lots of code review.

[ezio-melotti]

Can you upload the patch as a diff against the CPython repo?

[ethanfurman]

Here it is (I hope ;) .

[elibendersky]

I don't see docs in the patch, but perhaps that should be a separate patch to keep reviewing easier.

Also, Ethan, number the patch files in some way (like pep-435.1.patch, pep-435.N.patch) as they go through rounds of reviews.

[elibendersky]

OK, I sent another batch of reviews through the code review system - Ethan you should've gotten an email about it.

[elibendersky]

Regarding module vs. module_name for the extra param in the functional API, Guido rightly points out in bpo-17941 that __module__ is the class attribute, so "module" is a consistent choice.

[ethanfurman]

Incorporated comments.

[ethanfurman]

More adjustments due to review.

[ethanfurman]

Round 4. I wonder if I should have used two digits to number the patches. ;)