Skip to content

gh-133701: Fix incorrect __annotations__ on TypedDict defined under PEP 563 #133772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

gh-133701: Fix incorrect __annotations__ on TypedDict defined under PEP 563 #133772

merged 1 commit into from
May 14, 2025
+41 −4

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 9, 2025 •
edited by bedevere-app bot
Loading

@JelleZijlstra JelleZijlstra requested a review from AlexWaygood as a code owner May 9, 2025 15:50
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label May 9, 2025
This was referenced May 9, 2025
Closed
Closed
@JelleZijlstra JelleZijlstra merged commit 9836503 into python:main May 14, 2025
43 checks passed
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2025
@JelleZijlstra @miss-islington
pythongh-133701: Fix incorrect __annotations__ on TypedDict defined…
f570053 
… under PEP 563 (pythonGH-133772)

(cherry picked from commit 9836503)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 14, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 14, 2025
JelleZijlstra added a commit that referenced this pull request May 14, 2025
@miss-islington @JelleZijlstra
[3.14] gh-133701: Fix incorrect __annotations__ on TypedDict define…
d6cb8fa 
…d under PEP 563 (#134003)

GH-133772)
(cherry picked from commit 9836503)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

1 participant
@JelleZijlstra

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant