Skip to content

gh-132124: improve safety nets for creating AF_UNIX socket files #134085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

gh-132124: improve safety nets for creating AF_UNIX socket files #134085

merged 4 commits into from
May 21, 2025
+87 −5

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 16, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from gpshead as a code owner May 16, 2025 10:49
@bedevere-app bedevere-app bot mentioned this pull request May 16, 2025
Open
gpshead
gpshead approved these changes May 16, 2025
View reviewed changes
@gpshead gpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 16, 2025
gpshead
gpshead requested changes May 16, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 16, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@picnixz picnixz force-pushed the fix/multiprocessing/temp-dir-132124 branch from 3233fdc to 84f7020 Compare May 17, 2025 10:18
@picnixz
Copy link
Member Author

picnixz commented May 17, 2025

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 17, 2025

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from gpshead May 17, 2025 10:19
@thesamesam
Copy link
Contributor

Thank you! It works (and the change seems to have the semantics I'd expect).

gpshead
gpshead approved these changes May 21, 2025
View reviewed changes
Lib/multiprocessing/util.py
@@ -19,7 +19,7 @@
from . import process

__all__ = [
'sub_debug', 'debug', 'info', 'sub_warning', 'get_logger',
'sub_debug', 'debug', 'info', 'sub_warning', 'warn', 'get_logger',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: I'm going to leave 'warn' out of __all__ and rename the function to _warn as a modification to our 3.13 backport as it'd technically be an API change in a bugfix release otherwise.

@gpshead gpshead merged commit 1a07a01 into python:main May 21, 2025
44 of 47 checks passed
@miss-islington-app
Copy link

Thanks @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@picnixz @miss-islington
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
036d6a8 
pythonGH-134085)

* ensure that we can create AF_UNIX socket files
* emit a warning if system-wide temporary directory is used
(cherry picked from commit 1a07a01)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2025

3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@picnixz @miss-islington
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
adb75fc 
pythonGH-134085)

* ensure that we can create AF_UNIX socket files
* emit a warning if system-wide temporary directory is used
(cherry picked from commit 1a07a01)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2025

3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2025
gpshead pushed a commit that referenced this pull request May 21, 2025
@miss-islington @picnixz
[3.14] gh-132124: improve safety nets for creating AF_UNIX socket fil…
f8ced87 
…es (#134447)

GH-134085)

* ensure that we can create AF_UNIX socket files
* emit a warning if system-wide temporary directory is used
(cherry picked from commit 1a07a01)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz deleted the fix/multiprocessing/temp-dir-132124 branch May 23, 2025 12:22
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@picnixz @lkollar
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
d0cd049 
pythonGH-134085)

* ensure that we can create AF_UNIX socket files
* emit a warning if system-wide temporary directory is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

3 participants
@picnixz @thesamesam @gpshead

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant