Skip to content

gh-117596: Add more tests for os.path with invalid paths #134189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 19, 2025
Merged

gh-117596: Add more tests for os.path with invalid paths #134189

merged 11 commits into from
May 19, 2025
+243 −10

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 18, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 18, 2025
Open
@serhiy-storchaka serhiy-storchaka requested a review from encukou May 18, 2025 17:50
encukou
encukou reviewed May 19, 2025
View reviewed changes
encukou
encukou previously approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou
Copy link
Member

encukou commented May 19, 2025

Oh, was too fast, sorry! The changes look good; they need to pass tests :/

@encukou encukou dismissed their stale review May 19, 2025 15:25

Tests fail

@serhiy-storchaka serhiy-storchaka merged commit 871d269 into python:main May 19, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test-os-path-with-invalid-paths branch May 19, 2025 18:18
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
@serhiy-storchaka @miss-islington
pythongh-117596: Add more tests for os.path with invalid paths (pytho…
ba88b1d 
…nGH-134189)

(cherry picked from commit 871d269)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
@serhiy-storchaka @miss-islington
pythongh-117596: Add more tests for os.path with invalid paths (pytho…
29f6d52 
…nGH-134189)

(cherry picked from commit 871d269)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 19, 2025
serhiy-storchaka added a commit that referenced this pull request May 19, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-117596: Add more tests for os.path with invalid paths (GH-1…
da506b2 
GH-134266)

(cherry picked from commit 871d269)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 20, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-117596: Add more tests for os.path with invalid paths (GH-1…
7e67b36 
GH-134265)

(cherry picked from commit 871d269)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

2 participants
@serhiy-storchaka @encukou

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant