Skip to content

gh-134215: PyREPL: Do not show underscored modules by default during autocompletion #134267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
May 20, 2025
Merged

gh-134215: PyREPL: Do not show underscored modules by default during autocompletion #134267

merged 26 commits into from
May 20, 2025
+57 −5

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

Conversation

kevteg
Copy link
Contributor

@kevteg kevteg commented May 19, 2025 •
edited
Loading

  • Add _is_suggestion_match method to the ModuleCompleter module
  • Add new tests to check autocomplete behaviour with private and public methods

@kevteg
pythongh-134215: Improve ModuleCompleter module
fd0212d 
* Add _should_add_module_name method to the ModuleCompleter module
* Add new tests to check autocomplete behaviour on private method
@python-cla-bot
Copy link

python-cla-bot bot commented May 19, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

Most changes to Python blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

Most changes to Python blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

Most changes to Python blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@kevteg
Copy link
Contributor Author

kevteg commented May 19, 2025

@tomasr8 ready for your review!

StanFromIreland
StanFromIreland reviewed May 19, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed May 19, 2025
View reviewed changes
kevteg and others added 2 commits May 19, 2025 17:53
@kevteg
Update tests
4a2872a
@kevteg @StanFromIreland
Update Lib/test/test_pyrepl/test_pyrepl.py
e854d10 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
kevteg and others added 3 commits May 19, 2025 17:59
tomasr8
tomasr8 reviewed May 20, 2025
View reviewed changes
@tomasr8 tomasr8 changed the title gh-134215: Improve ModuleCompleter module gh-134215: PyREPL: Do not show underscored modules by default during autocompletion May 20, 2025
@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 20, 2025
tomasr8
tomasr8 reviewed May 20, 2025
View reviewed changes
ambv and others added 2 commits May 20, 2025 21:42
@ambv ambv merged commit a3a3cf6 into python:main May 20, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@kevteg @StanFromIreland
@tomasr8 @ambv @miss-islington
pythongh-134215: PyREPL: Do not show underscored modules by default d…
60d7a80 
…uring autocompletion (pythongh-134267)

(cherry picked from commit a3a3cf6)

Co-authored-by: Kevin Hernández <kevin.hernandez@unet.edu.ve>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@tomasr8
Copy link
Member

tomasr8 commented May 20, 2025

Congrats @kevteg !!

ambv added a commit that referenced this pull request May 20, 2025
@miss-islington @kevteg
@StanFromIreland @tomasr8 @ambv
[3.14] gh-134215: PyREPL: Do not show underscored modules by default …
69710b7 
…during autocompletion (gh-134388)

(cherry picked from commit a3a3cf6)

Co-authored-by: Kevin Hernández <kevin.hernandez@unet.edu.ve>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@kevteg @StanFromIreland
@tomasr8 @ambv @lkollar
pythongh-134215: PyREPL: Do not show underscored modules by default d…
611e3dd 
…uring autocompletion (pythongh-134267)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8

@StanFromIreland StanFromIreland

@ambv ambv

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

4 participants
@kevteg @tomasr8 @ambv @StanFromIreland

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant