Skip to content

gh-134160: Block multiple module initialization #134773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

gh-134160: Block multiple module initialization #134773

merged 4 commits into from
May 28, 2025
+24 −4

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

Conversation

encukou
Copy link
Member

@encukou encukou commented May 27, 2025 •
edited by github-actions bot
Loading

Change the tutorial to block multiple module initialization, and note the reference leak.

📚 Documentation preview 📚: https://cpython-previews--134773.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request May 27, 2025
Open
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 27, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 27, 2025
@encukou
Copy link
Member Author

encukou commented May 27, 2025

There's a better way to do this, but module state might work better in Chapter 2?

neonene
neonene reviewed May 27, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed May 27, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we don't have any dedicated section on subinterpreters. I'd be happy to do that in a follow-up.

StanFromIreland
StanFromIreland reviewed May 27, 2025
View reviewed changes
encukou and others added 2 commits May 27, 2025 17:38
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
AA-Turner
AA-Turner approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor suggestions, but otherwise let's get this merged quickly.

A

@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 27, 2025
@encukou @AA-Turner
Apply suggestions from code review
c562e2e 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner AA-Turner merged commit 469a564 into python:main May 28, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 28, 2025
@miss-islington-app
Copy link

Thanks @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou @AA-Turner @miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
bd36c93 
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou @AA-Turner @miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
6d5c370 
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
@encukou encukou deleted the extending-exec-once branch May 28, 2025 07:56
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington @encukou @AA-Turner
[3.14] gh-134160: Block multiple module initialization (GH-134773) (#…
998cedb 
…134827)

GH-134773)
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington @encukou @AA-Turner
[3.13] gh-134160: Block multiple module initialization (GH-134773) (#…
067df2b 
…134828)

GH-134773)
(cherry picked from commit 469a564)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity

@neonene neonene

@StanFromIreland StanFromIreland

@AA-Turner AA-Turner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

5 participants
@encukou @AA-Turner @ZeroIntensity @neonene @StanFromIreland

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant