Skip to content

Conversation

@zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented Mar 14, 2018

@zhangyangyu
Copy link
Member Author

backport to 3.6: #6115

@ambv
Copy link
Contributor

ambv commented Mar 14, 2018

As commented on the BPO issue: the problem described in this issue is fixed, by BPO-32227.

The wrapper returned by the @register decorator is calling dispatch() with the first argument's __class__. It can only ever be invalid if somebody deliberately wrote something invalid to the object's __class__. It's extremely unlikely.

We should not slow down calling of all generic functions on the basis that somebody might pass a non-type straight to dispatch().

@ambv ambv closed this Mar 14, 2018
@zhangyangyu zhangyangyu deleted the issue27984 branch March 14, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant