Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix bogus EntityAccessLimitException in RestrictedEntityLookup | mediawiki/extensions/Wikibase | master | +155 -89 | |
Add tracking category for exceeded entity limit | Comment Actions This is a very unideal situation. Wikidata_IB, one of the recommended packages, can trigger this error simply by having a script calling checkvalue, on a random item that looks empty in the Wikidata interface, even. To say this is confusing is an understatement. Is it possible to at least state the property that triggered this error? Not providing any information in the error message is not fine by any standard. Comment Actions This wrong number of entities accessed sounds suspiciously like T341957: Wrong number of Wikibase entities in NewPP limit report. Comment Actions Hi @Strainu, We're looking into this ticket and trying to replicate the error, but we're having difficulty. Could you please share any useful information regarding this? Thanks a lot! Comment Actions Change #1078679 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde): [mediawiki/extensions/Wikibase@master] Add tracking category for exceeded entity limit Comment Actions Change #1078679 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add tracking category for exceeded entity limit Comment Actions Change #1087936 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde): [mediawiki/extensions/Wikibase@master] Created RestrictedEntityLookupFactory as a service instead of RestrictedEntityLookup. Each parser will each have its respective RestrictedEntityLookup. Comment Actions Change #1091251 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde): [mediawiki/extensions/Wikibase@master] Fix wikidata entity usage tracking and access count Comment Actions Change #1087936 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix wikidata entity usage tracking and access count Comment Actions Change #1088225 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)): [mediawiki/extensions/Wikibase@master] Streamline RestrictedEntityLookup implementation Comment Actions When multiple parsers are created? Are these usages summarized to one? This patch doesn't consider non-parser accesses to Wikidata Items. One extension is using it this way (and using limits introduced in I70497b61ba8c45bc322d9818e735f65aaa69f052). Comment Actions Change #1088225 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Streamline RestrictedEntityLookup implementation Comment Actions Change #1100851 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde): [mediawiki/extensions/Wikibase@master] Comment change in RestrictedEntityLookup Comment Actions Change #1100851 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Comment change in RestrictedEntityLookup Comment Actions Change #1101531 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde): [mediawiki/extensions/Wikibase@master] The `EntityAccessLimitException` error check should be outside of the if `array_key_exists` if statement. Comment Actions Change #1101531 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix bogus EntityAccessLimitException in RestrictedEntityLookup Code of Conduct · GPL · |
parser performance report.
Problem: Example: BDD
As the page attempts to access the first 400 cast members of Wolff's Revier , we can see that the 0 count is incorrect. It has been reset after issuing the Lua error. Acceptance criteria: Important Notes
However, we do not expect there will be many new errors after the fix, this is because if the page does exceed the entity accessed limit, it would already show an existing error. Notes about entity properties However, we found out that whether the entity is included in the count depends on how the entities are being accessed. In the implementation where we are using the template from user @Strainu {{Listă de la Wikidata/test|pid=P6|qid=Q1}}, each of the values of the property (P6) are being checked for its statements ("a list (P2354)" or is "coextensive with (P3403)"), this is considered accessing the entity. Therefore, this is correct to include in the entity access count. However, in the implementation where we directly access a property at an entity {{ #property: P6 | from = Q1}}, the property values are not being checked for their statements. That is why these entity statements are not represented in the count. We feel that there is no work required in changing what's considered as an entity accessed. Currently Affected Pages
--Previous description-- While the error is correct, when checking the parser data in preview, I see "Number of Wikibase entities loaded 9/400", which is confusing. I believe there are 2 improvements than can be made:
Details |