Translators can help to update/add these messages at:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-gblrights-usergroups&namespace=8
which also include the following sub-messages when relevant:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Logentry-gblrights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-set&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-removed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-changed&namespace=8
Original task description follows:
Currently Special:Redirect/logid/163030247 on English Wikipedia. It is not clear what changed in target's user rights without performer's change reason.
Instead of showing previous and current rights and leaving it up to the end user to compare and find what's changed, let the code do the comparison and replace the current message with 2 different messages such as:
X added User:Y to Z user group (and vice versa)
This will be more descriptive than the current message and will show directly what has changed
Echo notifications for target user already does this:
Related Objects- Duplicates Merged Here
- T170513: Enhance user-rights log messages with diff-like visual styling
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older ChangesRestricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2024, 7:08 PM2024-07-07 19:08:17 (UTC+0)Comment ActionsI've came up with messages like these:
What do you think @Nemoralis?
There are up to four parts in the new log message: granted, revoked, changed expiration and kept intact, so that it is still possible to reconstruct a complete state of user groups based on a single entry (like it is now, with the from/to syntax) but the changes are IMO more visible.
Comment Actions
In T369466#10502069, @Nemoralis wrote:
I would prefer "Admin granted bureaucrat to LoremIpsum" format
I've thought about it a bit, but I think such a syntax of the log message might be troublesome when translating it into other languages. In some of them, the group name may need to be properly inflected or the surroundings might need to be adapted.
For instance, if English required a preposition before group name in this context, there would need to be dichotomy:
- Admin granted an administrator to LoremIpsum
- Admin granted a bureaucrat to LoremIpsum
In Polish the sentence would read Admin nadał uprawnienia administratora LoremIpsum, even though the group member name is administrator, so there would need to exist a separate wrapper message to put {{GRAMMAR}} on every group name (and perhaps for every of four actions, I'mnot sure whether all languages would follow the same rules for every action).
I believe that such grammar adaptation is doable in general, but the complexity of this log entry and number of interface messages it consists of would skyrocket.
On the other hand, the enumeration syntax I've proposed is – I believe – easier to adapt when translating (as it's not uncommon for enumerated items to be of different grammatical properties and languages tend to have means of coping with it).
Comment ActionsChange #1116528 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Refactor RightsLogFormatter
Comment ActionsChange #1116529 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Clearly show changes to user groups in rights log
Comment ActionsChange #1116530 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/GlobalUserrights@master] Clearly display changes to the global user groups
Comment ActionsChange #1116531 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/CentralAuth@master] Clearly display changes to the global user groups
Comment ActionsI've submitted patches that make the rights log like in comment T369466#10500632. I didn't, however, change the messages in the IRC format, as it would make the code much more messy and I'm not sure who would benefit from that.
Now, the log formatters in GlobalUserrights and CentralAuth extensions can reuse the same code as the base RightsLogFormatter, without need to ducplicate the code, as it was before.
Comment ActionsGood idea, they are now more readable what groups changed. Would like to see this on "set status locked" too.
In T369466#10515391, @Msz2001 wrote:
I didn't, however, change the messages in the IRC format, as it would make the code much more messy and I'm not sure who would benefit from that.
There are some tools relying on this but changing needs to update them.
Comment ActionsChange #1116528 merged by jenkins-bot:
[mediawiki/core@master] Refactor RightsLogFormatter
Comment ActionsChange #1116529 merged by jenkins-bot:
[mediawiki/core@master] Clearly show changes to user groups in rights log
Comment ActionsChange #1116531 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Clearly display changes to the global user groups
Comment ActionsChange #1116530 merged by jenkins-bot:
[mediawiki/extensions/GlobalUserrights@master] Clearly display changes to the global user groups
Nemoralis merged a task: T170513: Enhance user-rights log messages with diff-like visual styling.Feb 8 2025, 12:11 AM2025-02-08 00:11:14 (UTC+0)Nemoralis mentioned this in T170513: Enhance user-rights log messages with diff-like visual styling.Comment ActionsI think we can add this to Tech News. This has been discussed before on enwiki village pump.
Comment ActionsThis is now causing some troubles in translating these messages with the lego messages, to be exact, the usage of multiple colons in one sentence. The test message is:
Sysop changed group membership for User: granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
Neither English or my language (which is Chinese) would allow that (notice the User: granted: part; multiple colons). It could be better without using so many colons here, also easing the work of translating this lego message.
Sysop changed group membership for User - granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
This looks a bit better to me. Or just end the first sentence with a period, since the whole message will end with a list:
Sysop changed group membership for User. granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
The current state is causing trouble translating.
Comment ActionsWhen preparing the log message I inspired myself with the use of punctuation as in gblrights/setmodify log (see on Meta), that has this double colon as well
09:15, 2 November 2024 Sotiale (talk | contribs) changed wikis in "All existing wikis": added: tlywiki, suwikisource, blkwiktionary, btmwiktionary, gpewiki; removed: (none) (+newly created wikis)
I've noticed, however, that it's not a rule. For example gblrights/groupprms (see on Meta) uses colon only for separating the very first clause from the list of changes and there's no colon after added or removed.
21:15, 10 November 2024 Martin Urbanec (talk | contribs) changed global group permissions for Special:GlobalUsers/testing-group: added (none); removed abusefilter-modify, abusefilter-privatedetails, abusefilter-modify-restricted (deleting group)
For consistency, I think it would be best to stick to one of these two schemes. What you think @Lakejason0?
Comment Actions
在T369466#10533988中,@Msz2001写道:
When preparing the log message I inspired myself with the use of punctuation as in gblrights/setmodify log (see on Meta), that has this double colon as well
09:15, 2 November 2024 Sotiale (talk | contribs) changed wikis in "All existing wikis": added: tlywiki, suwikisource, blkwiktionary, btmwiktionary, gpewiki; removed: (none) (+newly created wikis)
I've noticed, however, that it's not a rule. For example gblrights/groupprms (see on Meta) uses colon only for separating the very first clause from the list of changes and there's no colon after added or removed.
21:15, 10 November 2024 Martin Urbanec (talk | contribs) changed global group permissions for Special:GlobalUsers/testing-group: added (none); removed abusefilter-modify, abusefilter-privatedetails, abusefilter-modify-restricted (deleting group)
For consistency, I think it would be best to stick to one of these two schemes. What you think @Lakejason0?
the second one would be great.
Comment ActionsChange #1118481 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Tweak rights change description
Comment ActionsChange #1118482 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/CentralAuth@master] Update GroupMembershipChangeLogFormatter test expected value
Comment ActionsI've submitted a patch that drops colons after granted, revoked and changed expiration of. The colon is still after kept without changes to signify that it isn't a next part of this "list of changes" but rather on the same level as "Sysop changed group membership for User:"
Example from a test case:
Sysop changed group membership for User: granted bureaucrat (temporary, until 12:34, 1 January 2016), revoked bot, changed expiration of administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
Comment ActionsMaybe "kept unchanged"? It would still be shorter than the current "kept without changes" and I still feel it fits somehow better (at least for me).
Comment Actions
In T369466#10535070, @Lakejason0 wrote:
Adverbials like "unchanged" would have to be after the object (groups here). Since the lego messages are split into "granted $1" "revoked $1", all the commas are added in codes using the common translated messages of punctuations, maybe just write "{{GENDER:$2|kept}} $1 without changes" or "{{GENDER:$2|kept}} $1 unchanged"?
I've did it this way
Comment ActionsThanks for the comments @Lakejason0, and thanks for making the changes @Msz2001. I've approved the patches; they should be merged later today, as there's a long merge queue right now.
I just want to note that while these messages are difficult to translate, and are an example of "lego" messages, they seem like the best we can do given the existing system: we have existing log entries that describe complex user group changes, each log entry can only display one list item on Special:Log, and we must somehow stuff all that information into it.
If we were designing the user right changes log from scratch, maybe we could do something more readable (like put user groups additions/removal/expiration-changes into separate log entries), but that's not feasible right now.
Also, as a translator, you should feel free to adjust the punctuation to your language. We had extra colons in English, but Chinese doesn't have to have them. We're now removing them from English, but you can still add them back in other languages, or user other punctuation, if it is necessary.
Comment ActionsChange #1118481 merged by jenkins-bot:
[mediawiki/core@master] Tweak spelling in rights log description
Comment ActionsChange #1118482 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Update GroupMembershipChangeLogFormatter test expected value
Comment ActionsFor User-notice (usually Tech News), i'm not sure how to write about this change. I think it sounds like a 2-parter, where we want to both: (A) inform users who read log pages that a useful change has been made, and (B) advise translators on where (and how?) to add/update the translations.
- Is that accurate?
- Is there an easy way to point translators towards the entire collection of new/updated messages?
From a glance at this random entry, it seems like relatively few translations exist so far https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-granted&namespace=8 but do we need to link translators to each of the (8?) new/updated entries individually?
Ah... maybe https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights&namespace=8 is what we want to link to? I see the qqq docs link to the sub-components, and maybe that's enough? [And/or, maybe this deserves a separate email to the translators-l@ mailing list?]
TLDR: Please could someone (@Msz2001 ?) approve or correct/improve this draft for Tech News? We might be able to get it into next week's edition, if it's ready in the next hour or so. Thanks!
- The log entries for each change to an editor's user-groups are now clearer, by specifying exactly what has changed, instead of the plain before and after listings. Translators can help to update the localized versions, including the new sub-messages that are linked from the message's documentation. Thanks to user Msz2001 for these improvements. [1]
my contribs on TranslateWiki, starting with Logentry-, ending with /pl).
There are three entry points:
- MediaWiki:Logentry-rights-rights
- MediaWiki:Logentry-rights-autopromote
- MediaWiki:Logentry-gblrights-usergroups
Not updating the above will keep the former behavior in that language for the specific log subtype
Comment ActionsAh, ok, so it might be clearer to give a specific listing... Maybe we could link to this task (instead of translatewiki directly), and have the listing of all 15 pages at the top of the Description here? I.e. (IIUC) Someone could add this:
Translators can help to update/add these messages at:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-gblrights-usergroups&namespace=8
which also include the following sub-messages when relevant:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Logentry-gblrights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-set&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-removed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-changed&namespace=8
Original task description follows:
[...]
Comment ActionsThat makes sense to me. (I can update the task description Saturday morning UTC, as I'm now on mobile - or if anyone wants to do it earlier, feel free to :) )
I'm okay with the proposed wording of the message, just point to here instead of the qqq of messages.
Comment ActionsSorry to reopen this task again, but Chinese are again facing difficulties in displaying the text that cannot be resolved without changes to the code.
The problem is, currently the code is using commaList and listToText to render the group names AND the clauses; however in Chinese those must be using different punctuations: for splitting a list, we will prefer to use ideographic comma 、, which is currently achieved by using commaList and listToText via the system message comma-separator. In Chinese this message is exclusively written as the ideographic comma, and ideographic comma CANNOT BE USED to split clauses.
Thus, we would need to split the clauses (granted, revoked, etc.) using semicolonList.
Comment Actions
In T369466#10593282, @Lakejason0 wrote:
Thus, we would need to split the clauses (granted, revoked, etc.) using semicolonList.
Even for English this would be an improvement. After you read granted autopatroller, you expect to read another user group, but often the next word is revoked or kept. It's a phenomenon similar to the
Comment ActionsChange #1124053 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Fix clause separator in RightsLogFormatter
Comment Actions
- Duplicates Merged Here
- T170513: Enhance user-rights log messages with diff-like visual styling
Event Timeline
I've came up with messages like these:
What do you think @Nemoralis?
There are up to four parts in the new log message: granted, revoked, changed expiration and kept intact, so that it is still possible to reconstruct a complete state of user groups based on a single entry (like it is now, with the from/to syntax) but the changes are IMO more visible.
In T369466#10502069, @Nemoralis wrote:I would prefer "Admin granted bureaucrat to LoremIpsum" format
I've thought about it a bit, but I think such a syntax of the log message might be troublesome when translating it into other languages. In some of them, the group name may need to be properly inflected or the surroundings might need to be adapted.
For instance, if English required a preposition before group name in this context, there would need to be dichotomy:
- Admin granted an administrator to LoremIpsum
- Admin granted a bureaucrat to LoremIpsum
In Polish the sentence would read Admin nadał uprawnienia administratora LoremIpsum, even though the group member name is administrator, so there would need to exist a separate wrapper message to put {{GRAMMAR}} on every group name (and perhaps for every of four actions, I'mnot sure whether all languages would follow the same rules for every action).
I believe that such grammar adaptation is doable in general, but the complexity of this log entry and number of interface messages it consists of would skyrocket.
On the other hand, the enumeration syntax I've proposed is – I believe – easier to adapt when translating (as it's not uncommon for enumerated items to be of different grammatical properties and languages tend to have means of coping with it).
Change #1116528 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Refactor RightsLogFormatter
Change #1116529 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Clearly show changes to user groups in rights log
Change #1116530 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/GlobalUserrights@master] Clearly display changes to the global user groups
Change #1116531 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/CentralAuth@master] Clearly display changes to the global user groups
I've submitted patches that make the rights log like in comment T369466#10500632. I didn't, however, change the messages in the IRC format, as it would make the code much more messy and I'm not sure who would benefit from that.
Now, the log formatters in GlobalUserrights and CentralAuth extensions can reuse the same code as the base RightsLogFormatter, without need to ducplicate the code, as it was before.
Good idea, they are now more readable what groups changed. Would like to see this on "set status locked" too.
In T369466#10515391, @Msz2001 wrote:I didn't, however, change the messages in the IRC format, as it would make the code much more messy and I'm not sure who would benefit from that.
There are some tools relying on this but changing needs to update them.
Change #1116528 merged by jenkins-bot:
[mediawiki/core@master] Refactor RightsLogFormatter
Change #1116529 merged by jenkins-bot:
[mediawiki/core@master] Clearly show changes to user groups in rights log
Change #1116531 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Clearly display changes to the global user groups
Change #1116530 merged by jenkins-bot:
[mediawiki/extensions/GlobalUserrights@master] Clearly display changes to the global user groups
I think we can add this to Tech News. This has been discussed before on enwiki village pump.
This is now causing some troubles in translating these messages with the lego messages, to be exact, the usage of multiple colons in one sentence. The test message is:
Sysop changed group membership for User: granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
Neither English or my language (which is Chinese) would allow that (notice the User: granted: part; multiple colons). It could be better without using so many colons here, also easing the work of translating this lego message.
Sysop changed group membership for User - granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
This looks a bit better to me. Or just end the first sentence with a period, since the whole message will end with a list:
Sysop changed group membership for User. granted: bureaucrat (temporary, until 12:34, 1 January 2016), revoked: bot, changed expiration of: administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
The current state is causing trouble translating.
When preparing the log message I inspired myself with the use of punctuation as in gblrights/setmodify log (see on Meta), that has this double colon as well
09:15, 2 November 2024 Sotiale (talk | contribs) changed wikis in "All existing wikis": added: tlywiki, suwikisource, blkwiktionary, btmwiktionary, gpewiki; removed: (none) (+newly created wikis)
I've noticed, however, that it's not a rule. For example gblrights/groupprms (see on Meta) uses colon only for separating the very first clause from the list of changes and there's no colon after added or removed.
21:15, 10 November 2024 Martin Urbanec (talk | contribs) changed global group permissions for Special:GlobalUsers/testing-group: added (none); removed abusefilter-modify, abusefilter-privatedetails, abusefilter-modify-restricted (deleting group)
For consistency, I think it would be best to stick to one of these two schemes. What you think @Lakejason0?
在T369466#10533988中,@Msz2001写道:When preparing the log message I inspired myself with the use of punctuation as in gblrights/setmodify log (see on Meta), that has this double colon as well
09:15, 2 November 2024 Sotiale (talk | contribs) changed wikis in "All existing wikis": added: tlywiki, suwikisource, blkwiktionary, btmwiktionary, gpewiki; removed: (none) (+newly created wikis)
I've noticed, however, that it's not a rule. For example gblrights/groupprms (see on Meta) uses colon only for separating the very first clause from the list of changes and there's no colon after added or removed.
21:15, 10 November 2024 Martin Urbanec (talk | contribs) changed global group permissions for Special:GlobalUsers/testing-group: added (none); removed abusefilter-modify, abusefilter-privatedetails, abusefilter-modify-restricted (deleting group)
For consistency, I think it would be best to stick to one of these two schemes. What you think @Lakejason0?
the second one would be great.
Change #1118481 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Tweak rights change description
Change #1118482 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/extensions/CentralAuth@master] Update GroupMembershipChangeLogFormatter test expected value
I've submitted a patch that drops colons after granted, revoked and changed expiration of. The colon is still after kept without changes to signify that it isn't a next part of this "list of changes" but rather on the same level as "Sysop changed group membership for User:"
Example from a test case:
Sysop changed group membership for User: granted bureaucrat (temporary, until 12:34, 1 January 2016), revoked bot, changed expiration of administrator (permanent, was: until 12:34, 3 February 2016), kept without changes: interface administrator
Maybe "kept unchanged"? It would still be shorter than the current "kept without changes" and I still feel it fits somehow better (at least for me).
In T369466#10535070, @Lakejason0 wrote:Adverbials like "unchanged" would have to be after the object (groups here). Since the lego messages are split into "granted $1" "revoked $1", all the commas are added in codes using the common translated messages of punctuations, maybe just write "{{GENDER:$2|kept}} $1 without changes" or "{{GENDER:$2|kept}} $1 unchanged"?
I've did it this way
Thanks for the comments @Lakejason0, and thanks for making the changes @Msz2001. I've approved the patches; they should be merged later today, as there's a long merge queue right now.
I just want to note that while these messages are difficult to translate, and are an example of "lego" messages, they seem like the best we can do given the existing system: we have existing log entries that describe complex user group changes, each log entry can only display one list item on Special:Log, and we must somehow stuff all that information into it.
If we were designing the user right changes log from scratch, maybe we could do something more readable (like put user groups additions/removal/expiration-changes into separate log entries), but that's not feasible right now.
Also, as a translator, you should feel free to adjust the punctuation to your language. We had extra colons in English, but Chinese doesn't have to have them. We're now removing them from English, but you can still add them back in other languages, or user other punctuation, if it is necessary.
Change #1118481 merged by jenkins-bot:
[mediawiki/core@master] Tweak spelling in rights log description
Change #1118482 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Update GroupMembershipChangeLogFormatter test expected value
For User-notice (usually Tech News), i'm not sure how to write about this change. I think it sounds like a 2-parter, where we want to both: (A) inform users who read log pages that a useful change has been made, and (B) advise translators on where (and how?) to add/update the translations.
- Is that accurate?
- Is there an easy way to point translators towards the entire collection of new/updated messages?
From a glance at this random entry, it seems like relatively few translations exist so far https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-granted&namespace=8 but do we need to link translators to each of the (8?) new/updated entries individually?
Ah... maybe https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights&namespace=8 is what we want to link to? I see the qqq docs link to the sub-components, and maybe that's enough? [And/or, maybe this deserves a separate email to the translators-l@ mailing list?]
TLDR: Please could someone (@Msz2001 ?) approve or correct/improve this draft for Tech News? We might be able to get it into next week's edition, if it's ready in the next hour or so. Thanks!
- The log entries for each change to an editor's user-groups are now clearer, by specifying exactly what has changed, instead of the plain before and after listings. Translators can help to update the localized versions, including the new sub-messages that are linked from the message's documentation. Thanks to user Msz2001 for these improvements. [1]
There are three entry points:
- MediaWiki:Logentry-rights-rights
- MediaWiki:Logentry-rights-autopromote
- MediaWiki:Logentry-gblrights-usergroups
Not updating the above will keep the former behavior in that language for the specific log subtype
Ah, ok, so it might be clearer to give a specific listing... Maybe we could link to this task (instead of translatewiki directly), and have the listing of all 15 pages at the top of the Description here? I.e. (IIUC) Someone could add this:
Translators can help to update/add these messages at:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-gblrights-usergroups&namespace=8
which also include the following sub-messages when relevant:
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-rights-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-granted&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-revoked&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-expiry-changed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=logentry-rights-autopromote-kept&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Logentry-gblrights-rights&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-set&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-removed&namespace=8
- https://translatewiki.net/wiki/Special:Translations?message=Rightslogentry-expiry-changed&namespace=8
Original task description follows:
[...]
That makes sense to me. (I can update the task description Saturday morning UTC, as I'm now on mobile - or if anyone wants to do it earlier, feel free to :) )
I'm okay with the proposed wording of the message, just point to here instead of the qqq of messages.
Sorry to reopen this task again, but Chinese are again facing difficulties in displaying the text that cannot be resolved without changes to the code.
The problem is, currently the code is using commaList and listToText to render the group names AND the clauses; however in Chinese those must be using different punctuations: for splitting a list, we will prefer to use ideographic comma 、, which is currently achieved by using commaList and listToText via the system message comma-separator. In Chinese this message is exclusively written as the ideographic comma, and ideographic comma CANNOT BE USED to split clauses.
Thus, we would need to split the clauses (granted, revoked, etc.) using semicolonList.
In T369466#10593282, @Lakejason0 wrote:Thus, we would need to split the clauses (granted, revoked, etc.) using semicolonList.
Even for English this would be an improvement. After you read granted autopatroller, you expect to read another user group, but often the next word is revoked or kept. It's a phenomenon similar to the
Change #1124053 had a related patch set uploaded (by Msz2001; author: Msz2001):
[mediawiki/core@master] Fix clause separator in RightsLogFormatter