Page MenuHomeIznoMar 1 2025, 12:17 AM
Tags
Referenced Files
F58583581: Screenshot 2025-03-03 at 16-29-45 Apollonius quadrilateral - Wikipedia.png
Mon, Mar 3, 3:31 PM
F58583579: Screenshot 2025-03-03 at 16-29-39 Apollonius quadrilateral - Wikipedia.png
Mon, Mar 3, 3:31 PM
F58523135: image.png
Mar 1 2025, 12:17 AM
F58523131: image.png
Mar 1 2025, 12:17 AM
Subscribers
matmarex
this discussion.

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:
https://en.wikipedia.org/w/index.php?title=2024_Men%27s_T20_World_Cup_Super_8_stage&oldid=1278076374&useparsoid=0#Teams :

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This concerns wikitext which is basically something of the form {{#tag:ref|Text<ref>Name</ref>}}. In this case it's going through {{efn}} which has a module underneath.

Details

SubjectRepoBranchLines +/-
Fixes to "Parsoid Fragment Support v2"mediawiki/core
ssastry added a comment.EditedMar 1 2025, 11:28 PM

I can reproduce this locally with this wikitext:

{{#tag:poem|Text<ref>Name</ref>}}

{{#tag:poem|Text<syntaxhighlight lang='php'>$a=1</syntaxhighlight>}}

{{#tag:indicator|<templatestyles src="GeoData/styles.css" />''foo''|name=bar}}

If I set $wgParsoidFragmentSupport = 'v2'; in my LocalSettings.php, I get the HTML output:

<div class="poem" typeof="mw:Extension/poem mw:Transclusion" about="#mwt2" id="mwAg" data-mw="{&quot;name&quot;:&quot;poem&quot;,&quot;attrs&quot;:{},&quot;body&quot;:{&quot;extsrc&quot;:&quot;Text'\&quot;`UNIQ--ref-00000000-QINU`\&quot;'&quot;},&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;#tag:poem&quot;,&quot;function&quot;:&quot;tag&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;Text<ref>Name</ref>&quot;}},&quot;i&quot;:0}}]}"><p id="mwAw">Text'"`UNIQ--ref-00000000-QINU`"'</p></div>

<div class="poem" typeof="mw:Extension/poem mw:Transclusion" about="#mwt6" id="mwBA" data-mw="{&quot;name&quot;:&quot;poem&quot;,&quot;attrs&quot;:{},&quot;body&quot;:{&quot;extsrc&quot;:&quot;Text'\&quot;`UNIQ--syntaxhighlight-00000002-QINU`\&quot;'&quot;},&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;#tag:poem&quot;,&quot;function&quot;:&quot;tag&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;Text<syntaxhighlight lang='php'>$a=1</syntaxhighlight>&quot;}},&quot;i&quot;:0}}]}"><p id="mwBQ">Text'"`UNIQ--syntaxhighlight-00000002-QINU`"'</p></div>

<meta typeof="mw:Extension/indicator mw:Transclusion" about="#mwt10" id="mwBg" data-mw="{&quot;name&quot;:&quot;indicator&quot;,&quot;attrs&quot;:{&quot;name&quot;:&quot;bar&quot;},&quot;body&quot;:{&quot;extsrc&quot;:&quot;'\&quot;`UNIQ--templatestyles-00000004-QINU`\&quot;'''foo''&quot;},&quot;html&quot;:&quot;'\&quot;`UNIQ--templatestyles-00000004-QINU`\&quot;'<i data-parsoid=\&quot;{}\&quot;>foo</i>&quot;,&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;#tag:indicator&quot;,&quot;function&quot;:&quot;tag&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;<templatestyles src=\&quot;GeoData/styles.css\&quot; />''foo''&quot;},&quot;name&quot;:{&quot;wt&quot;:&quot;bar&quot;}},&quot;i&quot;:0}}]}">

I think the fragment support code probably has some missing support for the #tag parser function.

gerritbot added a comment.Mar 2 2025, 12:46 AM

Change #1123779 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] WIP: Process strip markers recursively in split

gerritbot added a comment.Mon, Mar 3, 2:16 AM

Change #1123815 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[operations/mediawiki-config@master] Revert "Turn on Parsoid fragment support everywhere"

gerritbot added a comment.Mon, Mar 3, 2:42 PM

Change #1123815 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Turn on Parsoid fragment support everywhere"

Stashbot added a comment.Mon, Mar 3, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-03T14:54:37Z] <ihurbain@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123495|Change license for Russian Wikinews to CC-BY-4.0 (T387279)]], [[gerrit:1123815|Revert "Turn on Parsoid fragment support everywhere" (T387608)]] (duration: 11m 39s)

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#List-defined_references_not_working_on_Android_app.

The article rendered like this in Parsoid at the time:

Now it looks fixed:

ssastry renamed this task from Refs inside {{efn}} are now outputting strip markers in Parsoid to Parsoid's Fragment Mode support doesn't process strip markers recursively inside StripMarker::split.Mon, Mar 3, 6:55 PM
ssastry triaged this task as High priority.
ssastry edited projects, added Content-Transform-Team (Work In Progress); removed Parsoid.
ssastry updated Other Assignee, added: ssastry.
ssastry moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.
ssastry mentioned this in T388465: Parsoid extension no longer loaded on parsoidtest1001.Mon, Mar 10, 10:33 PM
gerritbot added a comment.Wed, Mar 12, 5:00 PM

Change #1127076 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@wmf/1.44.0-wmf.20] Process strip markers recursively in split

gerritbot added a comment.Wed, Mar 12, 5:03 PM

Change #1127076 abandoned by Subramanya Sastry:

[mediawiki/core@wmf/1.44.0-wmf.20] Process strip markers recursively in split

Reason:

The updated patch in master is now failing CI -- need to address that first.

gerritbot added a comment.Thu, Mar 13, 5:26 PM

Change #1123779 merged by jenkins-bot:

[mediawiki/core@master] Fixes to "Parsoid Fragment Support v2"

gerritbot added a comment.Thu, Mar 13, 5:46 PM

Change #1127076 restored by Jforrester:

[mediawiki/core@wmf/1.44.0-wmf.20] Process strip markers recursively in split

gerritbot added a comment.Thu, Mar 13, 9:53 PM

Change #1127076 abandoned by Subramanya Sastry:

[mediawiki/core@wmf/1.44.0-wmf.20] Fixes to "Parsoid Fragment Support v2"

Reason:

We won't backport this. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1127630 is also needed. So, we will just let them both ride the train. Then on Thursday, run rt-testing in Parsoid with this enabled, and then turn on v2 fragment mode the following week. So, we'll lose a week, but this has given us enough trouble that it is better to do a bit more thorough testing.

gerritbot added a comment.Mon, Mar 24, 4:42 AM

Change #1130343 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on Parsoid fragment support everywhere (take 2)

gerritbot added a comment.Mon, Mar 24, 1:25 PM

Change #1130343 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid fragment support everywhere (take 2)

Stashbot mentioned this in T389545: Variables in Parsoid content show older values compared to legacy.Mon, Mar 24, 1:33 PM
Stashbot mentioned this in T362715: Move credentials change to central login wiki.
Stashbot mentioned this in T374661: Charts are not compatible with Parsoid - show as raw SVG.
Stashbot added a comment.Mon, Mar 24, 1:54 PM

Privacy Policy · CC-BY-SA ·

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant