⚓ T54750 VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface

Tags

Referenced Files

	F36934546: obraz.png
	Mar 30 2023, 6:35 PM

	F36934544: obraz.png
	Mar 30 2023, 6:35 PM

	F36934541: obraz.png
	Mar 30 2023, 6:35 PM

	F36929314: image.png
	Mar 27 2023, 1:19 PM

	F36929306: en.wikipedia.org_wiki_Holcocera_immaculella_veaction=edit (3).png
	Mar 27 2023, 1:19 PM

	F36929304: en.wikipedia.org_wiki_Holcocera_immaculella_veaction=edit (2).png
	Mar 27 2023, 1:19 PM

	F36866803: image.png
	Feb 23 2023, 4:02 PM

	F36865505: image.png
	Feb 22 2023, 5:53 PM

View All 9 Files

Subscribers

Esanders

https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=568194420#I_can.27t_edit_the_references it has been proposed that it would be helpful to editors if they could edit references in the reference list, as well as where they appear inline.

"As just about every object you see on a page is directly editable with the VE, of course having the reflist not editable is counter-intuitive. "

This proposal would make T54736 either unnecessary or just a "workaround"/interim measure, depending on the timescale to implement.

#2 in the 2023 wishlist: master

+1 -1

Launch reference editors from ve.ce.MWReferencesListNode

nshahquinn-wmf updated the task description. (Show Details)Jul 22 2015, 11:23 PM

Jdforrester-WMF mentioned this in T183170: Some users seem to think that editing the references group is the way to add references.Jan 31 2018, 8:49 PM

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM

Aklapper removed a subscriber: • rmoen.

Copying my comment in from the other ticket, since I think it remains relevant here:

The major hangup on this is that it's going to expose the challenges with VE seeing references that're defined within templates. (Because of the current lack of a centralized way to edit references, this is only really visible to users from the "reuse citation" part of the cite dialog, where such references don't appear.) I suspect that if we accept having those ones greyed out in the list with a "this can't be edited here" tooltip, the rest of this should be fairly simple to do -- unless I'm not thinking of something, it's "just" hooking up a few bits of already-existing functionality and doing some UI work to expose them.

Following on from David's point, there are two ways the the reference list is rendered in the VisualEditor surface:

Using the HTML of the ref list supplied by Parsoid: This will include all references, included those defined inside templates (e.g. infoboxes), but the numbers will not necessarily map to those in VE's data model, so mapping from these references to editable references will be hard.
Generating a reference list by iterating over references in the document model: This will exclude references defined inside templates, but can easily be mapped back to the reference data in VE's data model. This list could be edited directly, or be used to launch a reference editor relatively easily.

(1) is used on the first load mostly for performance reasons (implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/411101) as it's a lot quicker to use the pre-generated HTML; rebuilding the reference list can be pretty slow on large pages. It also helps on wikis where most references are defined in templates, such as he.wiki.

Even if we switch to just using (2) this will mean that references are re-numbered when switching from read mode to edit mode.

From a UI perspective, we will need a way of showing the reference list context, probably by not embedding it but also thinking about where a user can click to show it (as clicking the reference list contents would now let you edit the list in some way)

I was thinking that a quick path forward would be for the reference list to offer a button that opened up a variant on the reuse dialog. In its context item would be the easiest place.

Even if we switch to just using (2) this will mean that references are re-numbered when switching from read mode to edit mode.

I think we're stuck with the references renumbering in the reflist if the user edits any of them anyway, so it might be better to do it up-front and have them stay consistent throughout the entire session.

In T54750#8641368, @DLynch wrote:

Even if we switch to just using (2) this will mean that references are re-numbered when switching from read mode to edit mode.

I think we're stuck with the references renumbering in the reflist if the user edits any of them anyway, so it might be better to do it up-front and have them stay consistent throughout the entire session.

It takes ~800ms to render the list on [[Barack Obama]], hence not doing it up-front. Also on he.wiki, the initial rendering is the only rendering with content.

In T54750#8727283, @Whatamidoing-WMF wrote:

Once it becomes possible to edit <references />, will editing through {{reflist}} require rich editing of templates?

Probably not – we already have a special-case support for templates that generate a reflist. Since we already treat it like a "real" references list, any new features should work here as well. For example, note how in

…despite being generated from a {{Reflist}} markup.

However, supporting references defined using {{reflist|refs= ... }} would require rich editing of templates. For example

Esanders updated the task description. (Show Details)Mar 27 2023, 1:35 PM

Change 903311 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Cite@master] Launch reference editors from ve.ce.MWReferencesListNode

https://patchdemo.wmflabs.org/wikis/6689bcdde2/wiki/Douglas_Adams?veaction=edit&section=26

Looks quite promising :-). One note: at the moment in the demo, after saving the changes, the script jumps to the link in the article. If it's not obvious, I think it would be good to stay where you started...

Hm... And I think double click is not working correctly. When I click [64] and then click [66] the edit window opens. I assume 1st click should only select as with other templates. I assume that is part of the WIP, but reporting just to be sure :)

Looks quite promising :-). One note: at the moment in the demo, after saving the changes, the script jumps to the link in the article. If it's not obvious, I think it would be good to stay where you started...

Yes - this will require some more upstream changes to fix.

I assume 1st click should only select as with other templates

These aren't real focusable templates, it's just a CSS hover and JS click handler. It could be changed to double click, but there is nothing to show after a single click (or any other interaction to be had, e.g. drag/drop).

We have previously implemented this single click -> dialog interaction with the categories list.

Currently it works like that (both in Chrome and FF):

1. before click	2. first click	3. second click

So first click could just change highlighted ref. That would work similar to tables and templates I guess.

but there is nothing to show after a single click (or any other interaction to be had, e.g. drag/drop).

You could always show an edit button like with templates.

Patch demo by ESanders (WMF) using patch(es) linked to this task:
Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~Patch demo by ESanders (WMF) using patch(es) linked to this task:~~

matmarex added a project: Editing-team (Kanban Board).May 17 2023, 4:07 PM

Change 903311 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Launch reference editors from ve.ce.MWReferencesListNode

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 17 2023, 5:00 PM

Change 922153 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Cite@master] Fix ref list click-to-edit on mobile

Change 922153 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix ref list click-to-edit on mobile

For Tech News, please confirm if this is an accurate summary, below?

Citations and footnotes can now be edited directly in the references section using VisualEditor. This feature request was voted #2 in the 2023 Community Wishlist Survey.

And confirm the timing: Will it be on the deployment train next week, or live on Monday, or other/later?
And is there a documentation page that it should link to, or just plaintext?
Thanks.

Citations and footnotes can now be edited directly in the references section using VisualEditor.

I wouldn't describe it like this (which I think is how the wish was described). You can't edit the citations in-place, like you can a image caption, but you can launch the editing dialog for each reference from the list. Maybe:

Citation and footnote editing can now be started from the reference list when using the visual editor.

The changes are in wmf10 which is on mediawiki.org (e.g. https://www.mediawiki.org/w/index.php?title=Composer&veaction=edit&section=10) and would already be on Wikipedias but for the train being blocked at the moment (T330216).

There is no documentation at the moment, just the text description.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

Change 950231 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Cite@master] Don't warn that reference list is uneditable

Patch demo by Novem Linguae using patch(es) linked to this task:

Change 950231 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Don't warn that reference list is uneditable

DLynch mentioned this in T350064: On some pages, some references disappear or render differently in Edit mode compared to Read mode.Oct 30 2023, 7:53 PM

Patch demo by Novem Linguae using patch(es) linked to this task was deleted:

awight moved this task from Incoming to Done on the WMDE-References-FocusArea board.Oct 23 2024, 7:09 AM