Phabricator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (543 w, 4 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders created T390288: Reflists of template-generated references show as interactive but aren't.
Fri, Mar 28, 12:18 PM · VisualEditor, Patch-For-Review, VisualEditor-MediaWiki-References
Esanders updated the task description for T388605: [Config] Deploy "+" menu (and new tools) to Phase 2 wikis.
Thu, Mar 27, 12:57 PM · Editing-team (Deployments)
Esanders closed T388603: [Config] Deploy "+" menu (and new tools) to Phase 0 wikis as Invalid.
Thu, Mar 27, 12:56 PM · Editing-team (Kanban Board)
Esanders moved T387501: Remove "Insert Graph" from VE for now from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
Tue, Mar 25, 6:29 PM · Editing-team (Kanban Board), MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T372981: Reclaim wiki resources on patch merge.

it has one or more patches that have not been either merged or abandoned OR

Note that PatchDemo also assigns a meta-status of dnm to any patch that has "DNM" or "DO NOT MERGE" in the subject. For the purposes of deleting wikis these patches can be assumed to be merged/abandoned.

Tue, Mar 25, 5:55 PM · Catalyst (ko)
Esanders added a comment to T389724: Allow to define a custom DiscussionTools empty state image path.

If you need a slightly hacky approach, you can replace the image with CSS, by setting the width of the image to 0, and replace with padding with a background image:

img.ext-discussiontools-emptystate-logo {
    display: block;
    width: 0;
    padding-left: 250px;
    background: url( yourimage ) center no-repeat;
}
Mon, Mar 24, 4:21 PM · patch-welcome, DiscussionTools

Thu, Mar 20

Esanders created T389191: Templates without TemplateData shows two error messages with different formatting.
Tue, Mar 18, 11:29 AM · VisualEditor, TemplateData

Mon, Mar 17

Esanders added a comment to T372981: Reclaim wiki resources on patch merge.

I like that, so all in the PatchDemo UI. In the past, have you done any on-wiki notifications (like we did for our recent cleanup)?

No, and we've not had complaints.

Mon, Mar 17, 10:33 AM · Catalyst (ko)
Esanders added a comment to T388581: [User research] Environment updates: how should this work.

what are some recent examples?

Mon, Mar 17, 10:29 AM · Catalyst (ko)

Sat, Mar 15

IKhitron awarded T388722: Error: No class registered by that key: null a Burninate token.
Thu, Mar 13, 1:47 PM · MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), Editing QA, Regression, Editing-team (Kanban Board), Wikimedia-production-error, EditCheck, VisualEditor
Esanders added a comment to T344029: Notification counter not shown on mobile (Minerva) when the user has no unseen alerts.

From your perspective should the counter on mobile reflect both notices and alerts?

! In T344029#10631502, @RHo wrote:

it would make sense for the count to be for the combined unread number.

Thu, Mar 13, 11:52 AM · MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Verified, Editing-team (Kanban Board), User-notice, Regression, MinervaNeue, Notifications (Echo), Growth-Team
Esanders added a comment to T388677: Opening search bar in Vector 2022 narrow causes vertical jump.

It appears the height jump is caused by the mw-logo being hidden.

Wed, Mar 12, 2:24 PM · Web-Team, Patch-For-Review, Desktop Improvements (Vector 2022)
Esanders added a comment to T388581: [User research] Environment updates: how should this work.

Copy is the best alternative we have at the moment to update, but is sub-optimal because:

  • You may have setup custom content on your wiki, this will need to be exported and imported
  • You may have already shared the link with colleagues, these will need to be updated
  • You usually want to delete the old wiki after creating the updated one.
  • Each time you create and delete a wiki you get a PatchDemoBot post on linked tasks. Having to scroll through them all to find the latest non-deleted wiki is problematic.
Wed, Mar 12, 2:14 PM · Catalyst (ko)

Tue, Mar 11

I was notified about a wiki that only contains a [DNM] patch:

Sun, Mar 9, 9:06 PM · Catalyst (ilopona)
Esanders raised the priority of T379428: [regression] VE mobile menu items unexpectedly bold from Low to Medium.

This was a task affecting the editing experience and we communicated the priority when filing the task. Not sure why it was lowered?

Thu, Mar 6, 4:36 PM · Unplanned-Sprint-Work, Web-Team (Q3 Sprint 4 (Mar 5, 2025 - Mar 19, 2025)), MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Regression, MinervaNeue, VisualEditor
Esanders added a comment to T344927: External link annotation is split into multiple in a visual diff.

Rougly what is happening here:

  • The differ works by bisecting the text and comparing smaller fragments
  • Sometimes we are comparing linked letters from the old revision with linked letters from the new revision which are equal for the purposes of the diff (characters are equal, and the links have the same target)
  • Because of this we have mixture of the link annotation from the old doc and the new doc. While the links are comparable, they have different originalDomElements, so when we re-render them we break up the link at these points, as a valid use case in Parsoid would be to preserve the user typing in adjacent-but-equal links.
Thu, Mar 6, 12:36 PM · Verified, Editing-team (Kanban Board), VisualEditor-VisualDiffs, VisualEditor-EditingTools, VisualEditor
Esanders triaged T363024: VisualDiff crashes on pages with complex/manual HTML changes as Low priority.

The issue is the following bit of inavlid HTML, where a text node ("The options for...") is placed directly under a <ul>:

<ul>The options for traditional BSN plan of study are: 
    <li style="margin-left:3em;">Four (4) semester Program of Study: please see attachment A </li>
    <li style="margin-left:3em;">Six (6) semester Program of Study: please see attachment B</li>
    <li style="margin-left:3em;">The accelerated BSN plan of study: please see attachment C</li>
    <li style="margin-left:3em;">The RN-BSN plan of study: please see attachment D.</li>
</ul>
Thu, Mar 6, 12:15 PM · VisualEditor-VisualDiffs
Esanders added a comment to T388046: Can't create any wikis on PatchDemo.

The above log mentions QuickInstantCommons, but even if I turn that off I get:

Wed, Mar 5, 6:45 PM · Catalyst (PatchDemo)
Esanders added a comment to T268631: Arabic and Waw letter و becomes part of link suffix but it should not (and it seems to not be part of $linkTrail).

@ppelberg @Esanders it looks like you were exploring this task. Do you have more to share on the previous progress and the reasons it was stalled?

Wed, Mar 5, 6:36 PM · LPL Technical Support, MediaWiki-Internationalization, I18n
Esanders created T388006: Toolbar not resizing correctly during and after pre-save edit check.
Wed, Mar 5, 2:41 PM · Verified, MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), EditCheck, Editing-team (Kanban Board), VisualEditor

Tue, Mar 4

Esanders added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8)

When was MediaWiki's grade A requirement raised to ES7?

Tue, Mar 4, 6:08 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript
Esanders added a comment to T372981: Reclaim wiki resources on patch merge.

For wkkis with tasks attached I would also wait for the task to be marked as resolved as well. A typical workflow for our team might involve:

  1. Create a wiki with patches, and maybe some test data
  2. Patches gets reviewed and merged
  3. QA reviews, and also may need PatchDemo wiki for reviewing (along side other environments, e.g. beta cluster).
  4. Patch is deployed, marked as resolved. Only at this point can the wiki be deleted.
Tue, Mar 4, 4:54 PM · Catalyst (ko)
Esanders added a comment to T387657: "not logged in" warning should be most important.

Note this is the same order as in the source editor:

From T355555 there will soon be a ve.newTarget hook.

Fri, Feb 28, 1:53 PM · Editing-team, Russian-Sites, DiscussionTools
Esanders added a comment to T344029: Notification counter not shown on mobile (Minerva) when the user has no unseen alerts.

The code comment describes the behaviour requested, so this is just an implementation error:

/ The circle should only appear if there are unseen notifications.
Thu, Feb 27, 7:06 PM · MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Verified, Editing-team (Kanban Board), User-notice, Regression, MinervaNeue, Notifications (Echo), Growth-Team
Esanders created T387456: Selection highlights in separate paragraphs move unnecessarily when typing quickly in another paragraph.
Thu, Feb 27, 1:56 PM · Verified, Editing-team (Kanban Board), MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), VisualEditor
Esanders created T387335: Allow ResourceLoader packageFiles to define multiple "main" files.
Feb 26 2025, 1:36 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader

Feb 25 2025

Esanders added a comment to T379102: [MILESTONE] Offer Usability Improvements as default-on feature at Phase 3 wikis (desktop).

Observations:

  1. The timestamp does not exactly match the way it is defined in this ticket: T310914. The timestamp in the mockup shows the exact timestamp and the date, but currently I am only seeing format like n days/months/years ago.
Feb 24 2025, 3:31 PM · Verified, Editing-team (Kanban Board), User-notice, TPP-Scaling, DiscussionTools

Feb 21 2025

Esanders added a comment to T227189: Easy to accidentally launch the editor while expanding a section.

Potentially we could do a small A/B test to see if expanding sections by default results in fewer editor launches (but the same number of editor completions).

Feb 21 2025, 11:29 PM · Editing-team, Design, DiscussionTools

Feb 18 2025

Esanders added a comment to T381655: FOUC when loading talk pages on mobile using Parsoid read views.

Both solutions seem hacky TBH since they are changing the default styles of a skin which is neither the responsibility of MobileFrontend or DiscussionTools. I recommended the latter given it removes the web team from blocking you from progress.

Feb 18 2025, 12:12 PM · Patch-For-Review, Web-Team, DiscussionTools
Esanders added a comment to T368554: Accessibility: users are unable to tab through the description field to the type setting.

The Editing part of this task is done. When signed off, we can just remove the Editing team tag and leave it with CommTech, instead of marking it as resolved.

Feb 12 2025, 3:44 PM · Verified, MW-1.44-notes (1.44.0-wmf.14; 2025-01-28), Community-Tech, Accessibility
Esanders added a comment to T95388: Try to find link in archive.org when direct scraping fails.

Yeah, just encountered that, if this is supposed to work, it does not for https://web.archive.org/web/*/https://kargormaslihat.gov.kz/ru/ispolvlast/
You can still put in archive URL directly but this feature would be so good if it was implemented fully.

Feb 6 2025, 5:48 PM · Verified, Editing-team (Kanban Board), Internet-Archive, VisualEditor, Citoid

Feb 4 2025

Terms of Use · Credits

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant