Skip to content

/ copilot-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display secret names as environment variables #720

Open
efekarakus opened this issue Mar 6, 2020 · 2 comments
Open

Display secret names as environment variables #720

efekarakus opened this issue Mar 6, 2020 · 2 comments
Labels
area/svc good first issue type/enhancement

Comments

@efekarakus
Copy link
Contributor

@efekarakus efekarakus commented Mar 6, 2020

Ask

Currently, if a user runs app show, under "Variables" we only display environment variables:

$ ecs-preview app show
....
Variables

  Name                      Environment         Value
  ECS_CLI_APP_NAME          test                api
  ECS_CLI_ENVIRONMENT_NAME  test                test
  ECS_CLI_LB_DNS            test                XXXX
  ECS_CLI_PROJECT_NAME      test                ecs-kudos
  MY_DYNAMODB_TABLE_NAME    test                ecs-kudos-test-api
  MY_QUEUE_URL              test                https://sqs.us-west-2.amazonaws.com/XXXX/SampleQueue

Since secrets are also injected as environment variables we should also display them under variables:

$ ecs-preview app show
....
Variables

  Name                      Environment         Value                      Is a secret?
  ...                                                                      no
  MY_DB_PASSWD              test                ssm/<parameter name>       yes
  OTHER_DB_PASSWD           test                secretsmanager/<ARN>       yes

Why?

I want to see all the available environment variable names (including secrets) when I run "app show".

I'm not particularly attached to the UX above, so feel free to propose something else.
@kohidave
Copy link
Contributor

@kohidave kohidave commented Mar 9, 2020 •
edited

Should we stick with the manifest style of grouping it under a different header? Secrets or something?
@efekarakus
Copy link
Contributor Author

@efekarakus efekarakus commented Mar 9, 2020

Sure that sounds good. It would make it easier to display too.

Secrets
  Name                      Environment         Value from                     
  MY_DB_PASSWD              test                ssm/<parameter name>       
  OTHER_DB_PASSWD           test                <ARN>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/svc good first issue type/enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kohidave @efekarakus
You can’t perform that action at this time.

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant