Add CMake aliases #2429

lukasm91 · 2019-08-24T12:37:01Z

GTest exports the following targets:

GTest::gtest
GTest::gtest_main
GTest::gmock
GTest::gmock_main

This targets should also be available when adding gtest with add_subdirectory (or FetchContent), because this should behave the same way as adding GTest with find_package. So somewhere, we should add the aliases to these targets, i.e.

add_library(GTest::gtest ALIAS gtest)
add_library(GTest::gtest_main ALIAS gtest_main)
add_library(GTest::gmock ALIAS gmock)
add_library(GTest::gmock_main ALIAS gmock_main)

I am not sure, where I should add these aliases.

gennadiycivil · 2019-10-24T03:53:54Z

Anything related to CMake is community supported. We do not use it internally and we are not in position to check. In general the maintainers would look for community consensus.

Mizux · 2020-01-09T21:36:20Z

My 2 cents,

`GTest` namespace

First this CMake install NAMESPACE (GTest) is defined here:

googletest/googletest/CMakeLists.txt

Line 98 in 306f375

set(cmake_package_name GTest)

then used here:

googletest/googletest/CMakeLists.txt

Line 105 in 306f375

NAMESPACE ${cmake_package_name}::

To use this variable ${cmake_package_name}, it should be defined somewhere else IMHO...
Edit: should be defined before including internal_utils.cmake:

googletest/googletest/CMakeLists.txt

Lines 90 to 91 in 306f375

    
           # Define helper functions and macros used by Google Test. 
        
           include(cmake/internal_utils.cmake)

`gtest` and `gtest_main` targets

these libraries are defined later using a custom function cxx_library:

googletest/googletest/CMakeLists.txt

Lines 128 to 129 in 306f375

    
           cxx_library(gtest "${cxx_strict}" src/gtest-all.cc) 
        
           cxx_library(gtest_main "${cxx_strict}" src/gtest_main.cc)

which call cxx_library_with_type:

googletest/googletest/cmake/internal_utils.cmake

Lines 197 to 203 in 306f375

    
           function(cxx_shared_library name cxx_flags) 
        
             cxx_library_with_type(${name} SHARED "${cxx_flags}" ${ARGN}) 
        
           endfunction() 
        
           function(cxx_library name cxx_flags) 
        
             cxx_library_with_type(${name} "" "${cxx_flags}" ${ARGN}) 
        
           endfunction()

which call the add_library:

googletest/googletest/cmake/internal_utils.cmake

Lines 147 to 150 in 306f375

    
           function(cxx_library_with_type name type cxx_flags) 
        
             # type can be either STATIC or SHARED to denote a static or shared library. 
        
             # ARGN refers to additional arguments after 'cxx_flags'. 
        
             add_library(${name} ${type} ${ARGN})

so we should try to add the add_library(... ALIAS ...) to this function IMHO

`gmock` and `gmock_main` targets

pretty the same story:

googletest/googlemock/CMakeLists.txt

Lines 89 to 107 in 7b1cf6d

    
           if (MSVC) 
        
             cxx_library(gmock 
        
                         "${cxx_strict}" 
        
                         "${gtest_dir}/src/gtest-all.cc" 
        
                         src/gmock-all.cc) 
        
             cxx_library(gmock_main 
        
                         "${cxx_strict}" 
        
                         "${gtest_dir}/src/gtest-all.cc" 
        
                         src/gmock-all.cc 
        
                         src/gmock_main.cc) 
        
           else() 
        
             cxx_library(gmock "${cxx_strict}" src/gmock-all.cc) 
        
             target_link_libraries(gmock PUBLIC gtest) 
        
             set_target_properties(gmock PROPERTIES VERSION ${GOOGLETEST_VERSION}) 
        
             cxx_library(gmock_main "${cxx_strict}" src/gmock_main.cc) 
        
             target_link_libraries(gmock_main PUBLIC gmock) 
        
             set_target_properties(gmock_main PROPERTIES VERSION ${GOOGLETEST_VERSION}) 
        
           endif()

note gmock CMakeLists.txt include the gtest one

googletest/googlemock/CMakeLists.txt

Lines 51 to 55 in 7b1cf6d

    
           # Instructs CMake to process Google Test's CMakeLists.txt and add its 
        
           # targets to the current scope.  We are placing Google Test's binary 
        
           # directory in a subdirectory of our own as VC compilation may break 
        
           # if they are the same (the default). 
        
           add_subdirectory("${gtest_dir}" "${gmock_BINARY_DIR}/${gtest_dir}")

note: gmock install rules seems to use an other macro/function:

googletest/googlemock/CMakeLists.txt

Line 121 in 306f375

install_project(gmock gmock_main)

defined here (EDIT: just adding targets to the googletest target):

googletest/googletest/cmake/internal_utils.cmake

Line 327 in 306f375

function(install_project)

(ed notice the of variable ${targets_export_name})

piotrzarycki · 2020-09-07T13:25:46Z

can i take this?

Mohammadmahdiamn · 2020-09-07T13:40:51Z

Do whatever you think is best.

…

On Mon, 7 Sep 2020, 17:57 Piotr Zarycki, ***@***.***> wrote: can i take this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2429 (comment)>, or unsubscribe <

derekmauro added the good first issue label Aug 18, 2020

google / googletest

Add CMake aliases #2429

Add CMake aliases #2429

lukasm91 commented Aug 24, 2019

gennadiycivil commented Oct 24, 2019

Mizux commented Jan 9, 2020 •

edited

`gtest` and `gtest_main` targets

`gmock` and `gmock_main` targets

piotrzarycki commented Sep 7, 2020

Mohammadmahdiamn commented Sep 7, 2020

google / googletest

Join GitHub today

Add CMake aliases #2429

Add CMake aliases #2429

Comments

lukasm91 commented Aug 24, 2019

gennadiycivil commented Oct 24, 2019

Mizux commented Jan 9, 2020 • edited

GTest namespace

gtest and gtest_main targets

gmock and gmock_main targets

piotrzarycki commented Sep 7, 2020

Mohammadmahdiamn commented Sep 7, 2020

Mizux commented Jan 9, 2020 •

edited

`GTest` namespace

`gtest` and `gtest_main` targets

`gmock` and `gmock_main` targets