Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPoor focus in snapshots from athena #1669
Open
Labels
Comments
|
It probably doesn't wait long enough for camerad to be completely focussed. Does it help if you increase the 3 second timeout to something large like 10 seconds?https://github.com/commaai/openpilot/blob/master/selfdrive/camerad/snapshot/snapshot.py#L41 Camerad now outputs a sharpness score. We should probably change the snapshot code to subscribe to that and detect when the image is properly focused before taking the snapshot (obviously with some max time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example snapshots
Still from driving video
Describe the bug
Focus appears to be off significantly in rear camera snapshots
How to reproduce or log data
Capture snapshot via athena.
Expected behavior
Snapshot with good focus.
Device/Version information (please complete the following information):
Additional context
Focus during normal driving footage is fine and looks great. Only the snapshots appear to be affected. I query snapshots constantly throughout the day and it always exhibits the same behavior. I thought maybe it was compression at play, but I'm starting to thing that it's not the issue.