Enable JuliaSyntax.jl as an alternative Julia parser #46372
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install JuliaSyntax as a stdlib * Install this as the default parser when the environment variable JULIA_USE_NEW_PARSER is set.
This is required because we'd like to set the binding during Base.__init__. This can be done with `Core.eval` but that doesn't work well in incremental compilation mode.
inkydragon
reviewed
Aug 17, 2022
deps/checksums/JuliaSyntax-25b737b1bbce259451f6d79997a25c541e7ab8c1.tar.gz/sha512
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This enables the use of JuliaSyntax.jl as the Julia parser for the runtime, which greatly improves parser error messages in various cases. As an experimental feature, this is only enabled if the
JULIA_USE_NEW_PARSER=trueenvironment variable is set.For now I've installed it after bootstrapping because this is the simplest (flisp parser still used for bootstrap). In the future we can solve bootstrapping but this isn't necessary right away.
API Versioning: Stdlib woes vs vendoring
The simplest way to get this working immediately was as a stdlib. However in retrospect this has several downsides:
JuliaSyntaxAPI is not at all stable. The only stable API for using this fromBaseshould beMeta.parse()andExpr. Therefore, I think users should not really be able to dousing JuliaSyntaxand get the version bundled with Base.Basesomeone is using. Users should be able to install a "normal" version ofJuliaSyntaxviaPkg.So I think having this as a stdlib doesn't really make sense and we are left with some kind of vendoring approach. I think what I'll try next is to include the parser at the end of building
Base.Having said all that, it should be easy to try this out already :-)