Skip to content

Use guaranteed binary and source compatibility between releases of Scalafmt #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 2 commits into from
Jul 24, 2018
Merged

Use guaranteed binary and source compatibility between releases of Scalafmt #260

nedtwigg merged 2 commits into from
Jul 24, 2018

Conversation

@joan38
Copy link
Contributor

@joan38 joan38 commented Jul 7, 2018

Fix for #252

@joan38 joan38 mentioned this pull request Jul 7, 2018
Merged
3 tasks
@joan38 joan38 force-pushed the scalafmt-fix branch 2 times, most recently from 1704067 to 9da5575 Compare July 7, 2018 13:02
@nedtwigg
Copy link
Member

nedtwigg commented Jul 8, 2018

Looks like the change breaks older versions of scalafmt?

@joan38
Copy link
Contributor Author

joan38 commented Jul 9, 2018 •
edited
Loading

This drops the support for scalafmt < v0.7.0-RC1. Is it good enough? It's a pretty old version...

@joan38
Copy link
Contributor Author

joan38 commented Jul 9, 2018 •
edited
Loading

I tried to run the tests with gradle test but it doesn't seem to be the way to do and the CONTRIBUTING.md doesn't specify how to run the tests...

@joan38 joan38 mentioned this pull request Jul 9, 2018
Closed
@nedtwigg
Copy link
Member

nedtwigg commented Jul 9, 2018

Great! All it needs now is updated CHANGES.md:

  • a summary of the change
  • a link to the newly created PR

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

@nedtwigg
Copy link
Member

nedtwigg commented Jul 17, 2018

bump

@joan38 joan38 mentioned this pull request Jul 24, 2018
Closed
@nedtwigg nedtwigg merged commit 4cbb787 into diffplug:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joan38 @nedtwigg

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant