Skip to content

allow "spotlessFiles" project property in gradle plugin to only target specific files #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 6 commits into from
Dec 13, 2018
Merged

allow "spotlessFiles" project property in gradle plugin to only target specific files #322

nedtwigg merged 6 commits into from
Dec 13, 2018

Conversation

@vmdominguez
Copy link
Contributor

@vmdominguez vmdominguez commented Dec 11, 2018

Added a -files switch to allow targeting specific files.

This can be part of a solution to #178, the first part being a script that uses git commands to retrieve a list of staged files.

JLLeitschuh
JLLeitschuh reviewed Dec 11, 2018
View reviewed changes
thc202
thc202 reviewed Dec 11, 2018
View reviewed changes
@vmdominguez
fix PR feedback
8c32c19 
- update change log to reflect namespaced property
- remove superfluous assert statement
- compile Patterns once
nedtwigg
nedtwigg requested changes Dec 12, 2018
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great except for a very subtle bug that's pretty easy to fix.

@vmdominguez vmdominguez changed the title allow "files" project property in gradle plugin to only target specific files allow "spotlessFiles" project property in gradle plugin to only target specific files Dec 12, 2018
@nedtwigg
Copy link
Member

nedtwigg commented Dec 12, 2018

This LGTM. I'll cut a release tomorrow unless somebody has more comments or another PR they'd like to get merged in.

@nedtwigg nedtwigg merged commit 249d3ca into diffplug:master Dec 13, 2018
@nedtwigg
Copy link
Member

nedtwigg commented Dec 13, 2018

Published as 3.17.0

@luis-fors-cb luis-fors-cb mentioned this pull request Apr 11, 2019
Merged
@shaka-b
Copy link

shaka-b commented May 16, 2019

Have you test the file pattern on window? On my windows machine the pattern matching used here always fails when using UNIX path seperator "/" as described in the README.

@nedtwigg
Copy link
Member

nedtwigg commented May 22, 2019

Might be worth creating a fresh issue for this.

@nedtwigg
Copy link
Member

nedtwigg commented Jun 5, 2020

FYI, -PspotlessFiles has been deprecated and will be removed. Migration path available here: #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh left review comments

@nedtwigg nedtwigg nedtwigg approved these changes

+1 more reviewer

@thc202 thc202 thc202 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vmdominguez @nedtwigg @shaka-b @JLLeitschuh @thc202

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant