New maven coordinates for 2.0.0 release of Scalafmt

[nsutcliffe]

Scalafmt now releases under org.scalameta rather than com.geirsson as of 2.0.0. Updating so that spotless will work with scalafmt 2.0.0+ (maintains backwards compatability of scalafmt prior to 2.0.0).

[nedtwigg]

Thanks for the PR to fix #415! Needs a few tweaks.

[nedtwigg]

Here is here, but it's not publishing back to GitHub for some reason...

[jbduncan]

Looking at the code in this PR, it occurs to me that we're missing a test that scalafmt 2.0.0+ works as intended. However, I don't have my IDE in front of me at the moment, so it's not easy for me to tell what exactly should be tested and where the test should go.

@nsutcliffe some guidance on this? :)

[nedtwigg]

Ah, great catch @nsutcliffe, one last change and I think we're good to merge.

Here's the ScalaFmt test: https://github.com/diffplug/spotless/blob/master/testlib/src/test/java/com/diffplug/spotless/scala/ScalaFmtStepTest.java

And here are similar tests for the KtLint step where we made sure that the different groups for the different versions work as expected:

spotless/testlib/src/test/java/com/diffplug/spotless/kotlin/KtLintStepTest.java

Lines 41 to 67 in dbf857a

	@Test
	public void worksShyiko() throws Exception {
	/ Must use jcenter because `com.andreapivetta.kolor:kolor:0.0.2` isn't available on mavenCentral.
	/ It is a dependency of ktlint.
	FormatterStep step = KtLintStep.create("0.31.0", TestProvisioner.jcenter());
	StepHarness.forStep(step)
	.testResource("kotlin/ktlint/basic.dirty", "kotlin/ktlint/basic.clean")
	.testException("kotlin/ktlint/unsolvable.dirty", assertion -> {
	assertion.isInstanceOf(AssertionError.class);
	assertion.hasMessage("Error on line: 1, column: 1\n" +
	"Wildcard import");
	});
	}
	@Test
	public void worksPinterest() throws Exception {
	/ Must use jcenter because `com.andreapivetta.kolor:kolor:0.0.2` isn't available on mavenCentral.
	/ It is a dependency of ktlint.
	FormatterStep step = KtLintStep.create("0.32.0", TestProvisioner.jcenter());
	StepHarness.forStep(step)
	.testResource("kotlin/ktlint/basic.dirty", "kotlin/ktlint/basic.clean")
	.testException("kotlin/ktlint/unsolvable.dirty", assertion -> {
	assertion.isInstanceOf(AssertionError.class);
	assertion.hasMessage("Error on line: 1, column: 1\n" +
	"Wildcard import");
	});
	}

[nedtwigg]

Add a test

[nsutcliffe]

I am aware tests are failing on travis; I know that scalafmt has changes some of the defaults in release 2.0.0; I'll investigate the differences against the changes and make sure they are as a result of changes to the defaults.

[nsutcliffe]

The defaults for align.openParenDefnSite changed to false in 1.6 (see the scalafmt documentation), although I note that they didn't release 1.6, so 2.0.0 is the first chance of us seeing this. I believe this fully explains the difference in the test data, and so have updated with new test data for the 2.0.0 tests.

[nedtwigg]

Looks great, thanks @nsutcliffe! If you'd like any changes to the credit I just pushed up, lemme know :) Otherwise I'll merge this tomorrow.

[nsutcliffe]

That's great, thank you for your prompt assistance :-)

[nedtwigg]

Released in x.24.0