We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #59, by using the getAllJava() method on SourceSet instead of getJava(). The main application where this is useful is projects that do joint Java/Groovy compilation, which sometimes requires putting Java source into the Groovy directory. getAllJava() correctly picks up all of these source files.
The test is a modified copy of the GoogleJavaFormatTest. The main oddity in this test is that a side-effect of the GradleIntegrationTest.write() methods is that a newline is always present at the end of the file. This means that you can't round trip a file through write()/read() and expect it to be the same. To avoid modifying that behavior, since I'm not sure how much other tests depend on it, I just re-read the groovy source after writing to ensure I could verify it wasn't changed by spotlessApply.
Sorry, something went wrong.
Detect all Java source by default
58f7da6
Fixes #59, by using the getAllJava() method on SourceSet instead of getJava(). The main application where this is useful is projects that do joint Java/Groovy compilation, which sometimes requires putting Java source into the Groovy directory. getAllJava() correctly picks up all of these source files. The test is a modified copy of the GoogleJavaFormatTest. The main oddity in this test is that a side-effect of the GradleIntegrationTest.write() methods is that a newline is always present at the end of the file. This means that you can't round trip a file through write()/read() and expect it to be the same. To avoid modifying that behavior, since I'm not sure how much other tests depend on it, I just re-read the groovy source after writing to ensure I could verify it wasn't changed by spotlessApply.
Looks great, thanks @ajoberstar! Does .getAllJava() automatically limit itself to .java files? e.g. no groovy files?
.getAllJava()
.java
Yep, the test validates this as an extra safety net.
d540ada
Great! Just validated on my local machine. I'll merge and release as 2.4.1 today.
Thanks!
Successfully merging this pull request may close these issues.