We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add artifact option to GoogleJavaFormatStep.
artifact
GoogleJavaFormatStep
The Google Java Format is not friendly for lambda. I've managed a customized artifact to improve it. This PR allows user to integrate home-brewed GJF with spotless.
Sorry, something went wrong.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this, needs:
@nedtwigg Thank you for your insight.
Should I keep the MAVEN_COORDINATE naming?
MAVEN_COORDINATE
Yes please :)
@nedtwigg Would you take another look? groupArtifact is used instead of mavenCoordinate.
groupArtifact
mavenCoordinate
Just a few nits and I think this can get merged. You need it, and that's good enough for it to get merged.
What I don't like about it is that I think this feature is very niche, and not many people will need it. In general, I think it's good to gate stuff like that behind a custom name to indicate "you probably don't need this if you're just exploring". But maybe I'm wrong, and there are more forked GJF versions out there than I realize. So I'm okay with the naming and API as-is.
custom
I'd like to let this cool off for 48 hrs to see if any other maintainers want to weigh-in, then I'll merge and release.
This looks great, all my concerns are satisfied. I'll merge and release sometime Thursday unless somebody objects between now and then.
@nedtwigg I forgot to add test for the feature. Please wait for my update.
@nedtwigg done adding unit tests
b778a4b
6757a42
@nedtwigg I've rebased the PR. It seems there is some problem with ci/circleci: assemble_testClasses cloning the repo. What should I do?
ci/circleci: assemble_testClasses
Sorry, I'm stalled on #950. You've gone your part, I'll do mine asap.
Please merge the latest origin/main into this PR. That should fix CI, at which point I can merge and release.
origin/main
feat: customize artifact for google java format
c478183
update change log add new ctor of State instead of changing existed ones change artifact to groupArtifact check groupArtifact content add tests for custom group artifact
4e30602
Published in plugin-gradle 5.15.2 and plugin-maven 2.14.0.
plugin-gradle 5.15.2
plugin-maven 2.14.0
FYI, palantir-java-format is a lambda-friendly fork of GJF which shipped in Spotless plugin-gradle 6.2.0 and plugin-maven 2.20.0.
palantir-java-format
plugin-gradle 6.2.0
plugin-maven 2.20.0
nedtwigg Awaiting requested review from nedtwigg
Successfully merging this pull request may close these issues.