cgi.py and rfc822.py unquote fixes

[quinndunkan]

BPO	573197
Files	cgi.diff rfc822.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2004-08-14.15:41:16.000>
created_at = <Date 2002-06-24.16:21:32.000>
labels = ['library']
title = 'cgi.py and rfc822.py unquote fixes'
updated_at = <Date 2004-08-14.15:41:16.000>
user = 'https://bugs.python.org/quinndunkan'

bugs.python.org fields:

activity = <Date 2004-08-14.15:41:16.000>
actor = 'jlgijsbers'
assignee = 'jlgijsbers'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2002-06-24.16:21:32.000>
creator = 'quinn_dunkan'
dependencies = []
files = ['4374', '4375']
hgrepos = []
issue_num = 573197
keywords = ['patch']
message_count = 3.0
messages = ['40411', '40412', '40413']
nosy_count = 2.0
nosy_names = ['jlgijsbers', 'quinn_dunkan']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue573197'
versions = ['Python 2.3']

[quinndunkan]

This makes cgi.parse_header() properly unquote header
parameters. E.g.,
given a header:

content-disposition: attachment;
filename="weird\\file\"name"

parse_header() should return ('attachment',
{'filename': 'weird\\file"name'}),
but the current parse_header() just strips the ""s, it
doesn't unquote the \s,
so you get too many \s in the output.

This could possibly use rfc822.unquote, but
rfc822.unquote doesn't unquote \s
either! This looks like a bug since immediately
preceeding the definition of
rfc822.unquote is

# XXX Should fix unquote() and quote() to be really
conformant.

The email package uses rfc822.unquote, which means its
msg.get_filename()
has the "too many \s" problem. So maybe I'll include a
patch for rfc822.py as
well, and send a patch to Barry for email/Util.py.

A quick glance through RFC 822 sheds no light on the
use of <> for quoted
*strings*, only for addr-spec. So I'm not sure what
kind of quoting goes in
in them, and "none" seems a reasonable guess, so I
didn't change it.

So does that make unquote() "really conformant"? Dunno...

I've got this feeling like rfc822.py is sort of
supposed to be subsumed by the
email package anyway...

Oh, and according to the RFC, the other thing not
allowed in ""s
is newline, but I wasn't sure if that was quoted with a
\. If so, that's
an easy fix. I have a feeling newlines in quoted
strings aren't a
great idea anyway since, even if legal, many simple parsers
will probably not like them.

[jlgijsbers]

Logged In: YES
user_id=469548

rfc822 and email have been fixed a while ago, but
cgi.parse_header() still needs to be fixed. I've submitted a
less intrusive patch at http://python.org/sf/1008597.

[jlgijsbers]

Logged In: YES
user_id=469548

cgi.parse_header() has now been fixed as well (rev 1.80).
Thanks for the report!