email/Message.py: del_param fails when specifying a header

[doko42]

BPO	873418
Nosy	@warsaw, @doko42
Files	message.patch: patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/warsaw'
closed_at = <Date 2004-08-16.15:01:55.000>
created_at = <Date 2004-01-09.00:08:57.000>
labels = ['library']
title = 'email/Message.py: del_param fails when specifying a header'
updated_at = <Date 2004-08-16.15:01:55.000>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2004-08-16.15:01:55.000>
actor = 'barry'
assignee = 'barry'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-01-09.00:08:57.000>
creator = 'doko'
dependencies = []
files = ['5778']
hgrepos = []
issue_num = 873418
keywords = ['patch']
message_count = 2.0
messages = ['45222', '45223']
nosy_count = 2.0
nosy_names = ['barry', 'doko']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue873418'
versions = ['Python 2.3']

[doko42]

[forwarded from http://bugs.debian.org/225421]

Consider the following code:

   import email.Message
   msg = email.Message()
   msg.add_header('Content-Disposition', 'attachment',
filename='bud.gif')
   msg.del_param('filename', 'Content-Disposition')

According to the documentation, this should be the
correct syntax.
However, ValueError is raised in del_param.

   Traceback (most recent call last):
     File "pybug.py", line 4, in ?
       msg.del_param('filename', 'Content-Disposition')
     File "/usr/lib/python2.3/email/Message.py", line
675, in del_param
       for p, v in self.get_params(header,
unquote=requote):
   ValueError: need more than 1 value to unpack

It seems to me like a simple mistake of the argument
order in the get_params call. The included patch fixes
it, at least my program works again (maybe the same
mistake is made in more places).

[warsaw]

Logged In: YES
user_id=12800

Patch accepted. Checked into Python 2.3 and 2.4 along with
test cases.