AIX POLLNVAL definition causes problems

[johnmarshall]

BPO	923315
Nosy	@akuchling
Files	j3.c: test program in C

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/akuchling'
closed_at = <Date 2004-08-07.17:22:30.000>
created_at = <Date 2004-03-25.18:06:51.000>
labels = ['library']
title = 'AIX POLLNVAL definition causes problems'
updated_at = <Date 2004-08-07.17:22:30.000>
user = 'https://bugs.python.org/johnmarshall'

bugs.python.org fields:

activity = <Date 2004-08-07.17:22:30.000>
actor = 'akuchling'
assignee = 'akuchling'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-03-25.18:06:51.000>
creator = 'john_marshall'
dependencies = []
files = ['1236']
hgrepos = []
issue_num = 923315
keywords = []
message_count = 2.0
messages = ['20316', '20317']
nosy_count = 2.0
nosy_names = ['akuchling', 'john_marshall']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue923315'
versions = ['Python 2.4']

[johnmarshall]

Under AIX (5.1 at least), POLLNVAL (from sys/poll.h)
is 0x8000. This causes a problem because it is stored
in a (signed) short (e.g., revents):

---

struct pollfd
{
int fd; /* file descriptor or file ptr */
short events; /* requested events */
short revents; /* returned events */
};

As such, the following tests and results are given:

ashort (%hx) = 8000, ashort (%x) = ffff8000
POLLNVAL (%hx) = 8000, POLLNVAL (%x) = 8000

ashort == POLLNVAL => 0
ashort == (short)POLLNVAL => 1

Note that the 'ashort == POLLNVAL' test is 0 rather
than 1 because (I believe) POLLNVAL is treated as a
signed integer, the ashort value is then promoted to
signed integer thus giving 0xffff8000, not 0x8000.

The problem arises because IBM has chosen to use a
negative short value (0x8000) in a signed short
variable. Neither Linux or IRIX have this problem
because they use POLLNVAL=0x20 which promotes to
0x20.

This situation will cause the test_poll to fail and
will certainly be a gotcha for AIX users.

I have added the following code to the selectmodule.c
to address the problem (mask out the upper 32 bits):

-----~ line 513:selectmodule.c
num = PyInt_FromLong(self->ufds[i].revents & 0xffff);

John

[akuchling]

Logged In: YES
user_id=11375

Applied to 2.4 HEAD; thanks!