os.startfile() doesn\'t accept Unicode filenames

[huening]

BPO	1007046
Nosy	@malemburg, @birkenfeld, @birkenfeld, @rhettinger
Files	posix-startfile.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2005-09-14.20:52:09.000>
created_at = <Date 2004-08-11.06:47:56.000>
labels = ['extension-modules']
title = "os.startfile() doesn\\'t accept Unicode filenames"
updated_at = <Date 2005-09-14.20:52:09.000>
user = 'https://bugs.python.org/huening'

bugs.python.org fields:

activity = <Date 2005-09-14.20:52:09.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2004-08-11.06:47:56.000>
creator = 'huening'
dependencies = []
files = ['1365']
hgrepos = []
issue_num = 1007046
keywords = []
message_count = 5.0
messages = ['22043', '22044', '22045', '22046', '22047']
nosy_count = 5.0
nosy_names = ['lemburg', 'georg.brandl', 'rhettinger', 'huening']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1007046'
versions = ['Python 2.3']

[huening]

WinXP, Python 2.3.4

os.startfile() seems to have problems with Unicode
filenames. Example:

>>> import tkFileDialog
>>> import os
>>> f = tkFileDialog.askopenfilename()
>>> type(f)
<type 'unicode'>
>>> os.startfile(f)

Traceback (most recent call last):
  File "<pyshell#10>", line 1, in -toplevel-
    os.startfile(f)
UnicodeEncodeError: 'ascii' codec can't encode
characters in position 14-16: ordinal not in range(128)
>>>

[birkenfeld]

Logged In: YES
user_id=1188172

Attaching a patch which should fix that.

[rhettinger]

Logged In: YES
user_id=80475

I'm unicode illiterate. Passing to MAL for review.

[malemburg]

Logged In: YES
user_id=38388

The path looks OK, but I can't test it on Windows
(os.startfile() is only available on Windows).

A note on style: you should always try to keep lines shorter
than 80 characters, e.g.:

--- CVS-Python/Modules/posixmodule.c    2005-08-15
10:15:27.000000000 +0200
+++ Dev-Python/Modules/posixmodule.c    2005-09-01
10:23:06.555633134 +0200
@@ -7248,7 +7248,8 @@
 {
        char *filepath;
        HINSTANCE rc;
-       if (!PyArg_ParseTuple(args, "s:startfile", &filepath))
+       if (!PyArg_ParseTuple(args, "et:startfile",
+                             Py_FileSystemDefaultEncoding,
&filepath))
                return NULL;
        Py_BEGIN_ALLOW_THREADS
        rc = ShellExecute((HWND)0, NULL, filepath, NULL,
NULL, SW_SHOWNORMAL);

[birkenfeld]

Logged In: YES
user_id=1188172

Checked this in now. posixmodule.c r2.340, r2.329.2.4.