running test_codecmaps_* takes too much effort

[ronaldoussoren]

BPO	1010952
Nosy	@malemburg, @loewis, @ronaldoussoren, @hyeshik

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/hyeshik'
closed_at = <Date 2005-12-10.17:48:22.000>
created_at = <Date 2004-08-17.19:13:49.000>
labels = ['library']
title = 'running test_codecmaps_* takes too much effort'
updated_at = <Date 2005-12-10.17:48:22.000>
user = 'https://github.com/ronaldoussoren'

bugs.python.org fields:

activity = <Date 2005-12-10.17:48:22.000>
actor = 'hyeshik.chang'
assignee = 'hyeshik.chang'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-08-17.19:13:49.000>
creator = 'ronaldoussoren'
dependencies = []
files = []
hgrepos = []
issue_num = 1010952
keywords = []
message_count = 8.0
messages = ['22104', '22105', '22106', '22107', '22108', '22109', '22110', '22111']
nosy_count = 6.0
nosy_names = ['lemburg', 'loewis', 'anthonybaxter', 'jlgijsbers', 'ronaldoussoren', 'hyeshik.chang']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1010952'
versions = ['Python 2.4']

[ronaldoussoren]

The only way I've found to actually run the codecmap tests is by
running it over and over again, downloading the missing files when
a test complains in between, until the tests no longer complains.

E.g
$ make test

• test_codecmap_jp complains about a missing file
• download this file
  $ make test
• test_codecmap_jp complains about another missing filie
• ...

Another problem: it is completely unclear where I should place the
downloaded files. I've worked around this by placing the files in
Lib/test and patching test_multibytecodec_support to look for the
files in os.path.dirname(file):

cvs diff: Diffing .
Index: test_multibytecodec_support.py
=========================================
==========================
RCS file: /cvsroot/python/dist/src/Lib/test/
test_multibytecodec_support.py,v
retrieving revision 1.5
diff -r1.5 test_multibytecodec_support.py
165a166

    self.mapfilename = 

os.path.join(os.path.dirname(file), self.mapfilename)

It would be nice if there were a document that described what
should be done to run these tests, adding the required files to CVS
would be fine too :-)

[ronaldoussoren]

Logged In: YES
user_id=580910

test_normalization suffers from a simular problem.

[loewis]

Logged In: YES
user_id=21627

Adding the files to the CVS is unacceptable, because they
would then end up in the distribution, and their size is
considered unacceptable for distribution (let alone
copyright issues with these files).

[anthonybaxter]

Logged In: YES
user_id=29957

Could we at least get a single tarball/zip file of all of
the files? At the moment, it takes a serious amount of
effort to fetch all the files.

[jlgijsbers]

Logged In: YES
user_id=469548

How about adding the files to nondist?

[malemburg]

Logged In: YES
user_id=38388

Just a suggestion:

Why don't we add a new resource option to the test scripts
and then have the tests download the files from the Internet
as necessary ?!

[hyeshik]

Logged In: YES
user_id=55188

I wrote a patch that draws on lemburg's suggestion.
Please test it: SF bpo-1276356.

[hyeshik]

Logged In: YES
user_id=55188

Fixed in r41637. Thank you!