-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-115119: defer removal of bundled libmpdec to 3.16 #133997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Oops, this seems to be not just a docs patch. I hope this still ok for backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much to say but I'm neutral on delaying the removal.
What is the rationale for defering the removal? |
You can see the issue thread. For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now #134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.) |
I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04. |
FYI, I restored removal PR: #133964. I think libmpdec can be installed from PPA for PHP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This, probably, requires approval from the release manager. Though, @hugovk removed request for review. |
Deferring a breaking change is always a good thing :-) |
An RM decision isn't needed for normal feature changes in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting merge
docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!
|
libmpdec
sources #115119📚 Documentation preview 📚: https://cpython-previews--133997.org.readthedocs.build/