Skip to content

gh-133319: Use python versioning in msgfmt & pygettext #134205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 19, 2025

Simplest approach maintaining full backwards compatibility. We cannot use the version of the python running the script, updating this number every few years is not overly complex, it can be picked up by any pr modifying the file.

@StanFromIreland
Copy link
Contributor Author

Request: @serhiy-storchaka

@encukou
Copy link
Member

encukou commented May 28, 2025

This would put the burden of updating the numbers on the release manager, who bumps the CPython version. I doubt they'll want that.

Can you find a way to do this with less maintenance overhead?

@StanFromIreland
Copy link
Contributor Author

StanFromIreland commented May 28, 2025

IMO it shouldn’t fall on the release manager, since the file won’t have changed anyway. In my mind I think it should just be done as part of whatever pr that modifies the script in a given version.

Using the version of the python running it will be misleading.

@encukou
Copy link
Member

encukou commented May 28, 2025

Ah. Could you document that expectation; perhaps put the command to do it in a comment?

@StanFromIreland
Copy link
Contributor Author

perhaps put the command to do it in a comment?

I can do that.

@encukou
Copy link
Member

encukou commented May 29, 2025

Sorry, I assumed the discussion is further along.
First let's clarify what the versioning scheme should be; see discussion on the issue. After that, it'll be time to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant