Skip to content

gh-134208: remove dead AC directives for _curses.window.{chgat,getstr,instr} #134325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 8 commits into from
May 26, 2025
Merged

gh-134208: remove dead AC directives for _curses.window.{chgat,getstr,instr} #134325

picnixz merged 8 commits into from
May 26, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented May 20, 2025 •
edited by bedevere-app bot
Loading

This can be merged before or after #134283 was a sprint-dedicated issue, I think it's better not to bother new contributors so I'll hold the merge and resolve the conflicts myself later this week (it's not a pressing matter).

@bedevere-app bedevere-app bot mentioned this pull request May 20, 2025
Closed
@picnixz picnixz changed the title gh-134208: remove dead AC directives for _curses.window.{getch,getstr,instr} gh-134208: remove dead AC directives for _curses.window.{chgat,getstr,instr} May 20, 2025
@picnixz picnixz mentioned this pull request May 20, 2025
Merged
@picnixz picnixz requested a review from gpshead May 24, 2025 06:43
@picnixz picnixz self-assigned this May 25, 2025
@picnixz picnixz merged commit 29e8115 into python:main May 26, 2025
42 checks passed
@picnixz picnixz deleted the fix/curses/better-clinic-134208 branch May 26, 2025 08:52
@picnixz
Copy link
Member Author

picnixz commented May 26, 2025

Considering #134283 has been merged back into 3.14, I'll also backport this.

@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label May 26, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented May 26, 2025

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

picnixz added a commit to picnixz/cpython that referenced this pull request May 26, 2025
@picnixz
[3.14] pythongh-134208: remove dead AC directives for `_curses.window…
9ab72a9 
….{chgat,getstr,instr}` (pythonGH-134325)

(cherry picked from commit 29e8115)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
picnixz added a commit that referenced this pull request May 26, 2025
@picnixz
[3.14] gh-134208: remove dead AC directives for `_curses.window.{chga…
ed52549 
…t,getstr,instr}` (#134701)

(cherry picked from commit 29e8115)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-134208: remove dead AC directives for `_curses.window.{chgat…
1fb095c 
…,getstr,instr}` (python#134325)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-134208: remove dead AC directives for `_curses.window.{chgat…
13f8f94 
…,getstr,instr}` (python#134325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@picnixz picnixz

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @gpshead

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant