We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly just making sure things are under 80 characters and fixing a few incorrectly placed left braces. I also removed const from instances of _zstd_state* const mod_state since a) it was making some lines go over 80 characters b) it is unnecessary and c) it better matches the CPython style.
const
_zstd_state* const mod_state
This is the final todo left in #132983 🎉
Sorry, something went wrong.
Make _zstd C code PEP 7 compliant
6275ad0
Wrap a few more lines
0e15503
Remove trailing whitespace
89825a4
973b8f6
Thanks @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. 🐍🍒⛏🤖
pythongh-132983: Make _zstd C code PEP 7 compliant (pythonGH-134605)
89f718b
Make _zstd C code PEP 7 compliant (cherry picked from commit 973b8f6) Co-authored-by: Emma Smith <[email protected]>
3.14 branch.
Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 973b8f6.
What do you need to do:
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1241/builds/5870
Failed tests:
Summary of the results of the build (if available):
==
Traceback (most recent call last): Traceback (most recent call last): File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 616, in test_multiprocessing out, err = check_output([self.envpy(real_env_dir=True), '-c', ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 'from multiprocessing import Pool; ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 'pool = Pool(1); ' ^^^^^^^^^^^^^^^^^^ 'print(pool.apply_async("Python".lower).get(3)); ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 'pool.terminate()']) ^^^^^^^^^^^^^^^^^^^^ File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 58, in check_output raise subprocess.CalledProcessError( p.returncode, cmd, out, err) subprocess.CalledProcessError: Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_oln4cn7v\\tmp5x1oqj4y\\Scripts\\python3.15t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.
[3.14] gh-132983: Make _zstd C code PEP 7 compliant (GH-134605) (#134609
38a3824
) GH-134605) Make _zstd C code PEP 7 compliant (cherry picked from commit 973b8f6) Co-authored-by: Emma Smith <[email protected]>
Hm, that buildbot failure looks unrelated I think.
cc946d8
81f1790
gpshead gpshead approved these changes
Successfully merging this pull request may close these issues.