-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-134657: Remove newly added private names from asyncio.__all__ #134665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This removes the names that were added in 3.14, so we can backport to the 3.14 branch. We can remove the remaining private names for 3.15 only in the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know that I'm a code owner of the ssl
tests in asyncio...
Misc/NEWS.d/next/Library/2025-05-25-11-02-05.gh-issue-134657.3YFhR9.rst
Outdated
Show resolved
Hide resolved
…YFhR9.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
As I commented on the issue, I don't see value in making these changes, it changes almost 47 files which I was trying to avoid in the first place. All of these would be removed in 3.16 anyways so I think it is fine to keep it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! these should not have been added to the __all__
public API surface.
Thanks @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-134665) (cherry picked from commit 797abd1) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This removes the names that were added in 3.14, so we can backport to the 3.14 branch.
We can remove the remaining private names for 3.15 only in the main branch.
__all__
#134657