Skip to content

gh-134657: Remove newly added private names from asyncio.__all__ #134665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 25, 2025

This removes the names that were added in 3.14, so we can backport to the 3.14 branch.
We can remove the remaining private names for 3.15 only in the main branch.

This removes the names that were added in 3.14, so we can backport to the 3.14 branch.
We can remove the remaining private names for 3.15 only in the main branch.
picnixz
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that I'm a code owner of the ssl tests in asyncio...

…YFhR9.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@kumaraditya303
Copy link
Contributor

As I commented on the issue, I don't see value in making these changes, it changes almost 47 files which I was trying to avoid in the first place. All of these would be removed in 3.16 anyways so I think it is fine to keep it for now.

gpshead
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! these should not have been added to the __all__ public API surface.

@kumaraditya303 kumaraditya303 merged commit 797abd1 into python:main Jul 9, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
pythonGH-134665)

(cherry picked from commit 797abd1)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 9, 2025
…__ (#136455)

GH-134665)
(cherry picked from commit 797abd1)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

4 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant