-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
(gh-134817) Documents [Timed]RotatingFileHandler shouldRollover method #134818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3cbc934
to
3d696db
Compare
Thanks @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Thanks @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ethod (pythonGH-134818) (cherry picked from commit 7be5916) Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com> Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
…ethod (pythonGH-134818) (cherry picked from commit 7be5916) Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com> Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
@AllenSH12 Thanks for the patch - for some reason, the backport PRs don't appear to have registered your signature of the CLA (perhaps it relates to your email address). Could you please sign again so that the PRs for 3.13 and 3.14 can be merged? Thanks! |
You're welcome @vsajip I see the backporting PRs have been merged now, guessing everything is good with the CLA? |
Yes, I'd set them up to auto-merge once the block was removed, which you did by signing again, I guess 😄 |
…over methods
RotatingFileHandler.shouldRollover()
andTimedRotatingFileHandler.shouldRollover()
#134817📚 Documentation preview 📚: https://cpython-previews--134818.org.readthedocs.build/