Skip to content

bpo-30249: Improve struct.unpack_from() error messages #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangyangyu merged 2 commits into from
Mar 10, 2018
Merged

bpo-30249: Improve struct.unpack_from() error messages #6059

zhangyangyu merged 2 commits into from
Mar 10, 2018

Conversation

@zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented Mar 10, 2018 •
edited by bedevere-bot
Loading

@zhangyangyu zhangyangyu added the type-feature A feature request or enhancement label Mar 10, 2018
serhiy-storchaka
serhiy-storchaka reviewed Mar 10, 2018
View reviewed changes
Modules/_struct.c Outdated
if (offset < 0) {
if (offset + self->s_size > 0) {
PyErr_Format(StructError,
"no space to unpack %zd bytes at offset %zd",
Copy link
Member

@serhiy-storchaka serhiy-storchaka Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better sound as "not enough data" or like.

Copy link
Member Author

@zhangyangyu zhangyangyu Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. That's my first draft.

@zhangyangyu zhangyangyu merged commit c10b288 into python:master Mar 10, 2018
@zhangyangyu zhangyangyu deleted the issue30249 branch March 10, 2018 18:58
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@zhangyangyu @jo2y
bpo-30249: Improve struct.unpack_from() error messages (pythonGH-6059)
1cf765b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangyangyu @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant