Skip to content

[3.7] bpo-33018: Improve issubclass() error checking and message. (GH-5944) #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Mar 22, 2018
Merged

[3.7] bpo-33018: Improve issubclass() error checking and message. (GH-5944) #6188

miss-islington merged 1 commit into from
Mar 22, 2018

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 22, 2018 •
edited by bedevere-bot
Loading

This improves error message for situations when a non-class is
checked w.r.t. an abstract base class.
(cherry picked from commit 40472dd)

Co-authored-by: jab [email protected]

https://bugs.python.org/issue33018

@jab @miss-islington
bpo-33018: Improve issubclass() error checking and message. (pythonGH…
a633c7f 
…-5944)

This improves error message for situations when a non-class is
checked w.r.t. an abstract base class.
(cherry picked from commit 40472dd)

Co-authored-by: jab <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Mar 22, 2018
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 22, 2018

@ilevkivskyi: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 346964b into python:3.7 Mar 22, 2018
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 22, 2018

Thanks!

@miss-islington miss-islington deleted the backport-40472dd-3.7 branch March 22, 2018 11:49
@raamana raamana mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @ilevkivskyi @the-knights-who-say-ni @bedevere-bot @jab

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant