bpo-33123: pathlib: Add missing_ok parameter to Path.unlink

[rbu]

Similarly to how several pathlib file creation functions have an "exists_ok" parameter, we should introduce "missing_ok" that makes removal functions not raise an exception when a file or directory is already absent. IMHO, this should cover Path.unlink and Path.rmdir. Note, Path.resolve() has a "strict" parameter since 3.6 that does the same thing. Naming this of this new parameter tries to be consistent with the "exists_ok" parameter as that is more explicit about what it does (as opposed to "strict").

https://bugs.python.org/issue33123

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[rbu]

CLA is signed and submitted.

[amirouche]

I don't think it's worth changing the name of the file to something sort of explicit such as fileMissing. I'd rather not surprise the reader and use what seems the default in the tests file ie. fileA here too.

WDYT?

[rbu]

Agreed. fileA actually exists, but I changed to fileAAA which seems to be used for a non-existing file in other tests.

[pitrou]

A simple enough addition. LGTM.

[miss-islington]

@rbu: Status check is done, and it's a success ✅ .

[csabella]

Thank you, @pitrou, for the review.