-
-
Notifications
You must be signed in to change notification settings - Fork 867
Split translating.rst
into pages for Translators and Coordinators
#1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@StanFromIreland I like this approach to splitting this up in the devguide I did a quick skim of the document for coordinators, and it's looking really good. I'll do a more thorough review on the weekend. Thanks for the effort and pinging me to take a look. 💯 💐 cc/ @encukou It's cool to see this draft PR 👍🏼 |
I haven't added any new content, I have so far just split the existing text. I think it is generally preferred to not mix new text to make it easier to review, and do it in a separate pull request? I do plan to expand both sections (starting with that for translators) right after if this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @StanFromIreland for this helpful improvement. If you agree with the suggested changes, I am happy to merge. Alternatively, we can iterate on those suggestions if needed.
Ah, your suggestions modify the existing wording, which I already have a few patches (& questions) for. I can commit them for now since they are improvements, and we can iterate further on them in the next prs. |
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Thanks @StanFromIreland. I'm looking forward to the next PR. |
I propose that the existing page be split into two pages, a page for each key audience, coordinators, and translators. This, will help keep the pages organized allowing for better expansion. That is, to @jwjacobson) and @willingc).
📚 Documentation preview 📚: https://cpython-devguide--1575.org.readthedocs.build/