Skip to content

Split translating.rst into pages for Translators and Coordinators #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jun 13, 2025

I propose that the existing page be split into two pages, a page for each key audience, coordinators, and translators. This, will help keep the pages organized allowing for better expansion. That is, to @jwjacobson) and @willingc).


📚 Documentation preview 📚: https://cpython-devguide--1575.org.readthedocs.build/

@willingc
Copy link
Collaborator

@StanFromIreland I like this approach to splitting this up in the devguide I did a quick skim of the document for coordinators, and it's looking really good. I'll do a more thorough review on the weekend. Thanks for the effort and pinging me to take a look. 💯 💐

cc/ @encukou It's cool to see this draft PR 👍🏼

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jun 13, 2025

I haven't added any new content, I have so far just split the existing text. I think it is generally preferred to not mix new text to make it easier to review, and do it in a separate pull request?

I do plan to expand both sections (starting with that for translators) right after if this is merged.

@StanFromIreland StanFromIreland marked this pull request as ready for review June 14, 2025 18:24
willingc
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @StanFromIreland for this helpful improvement. If you agree with the suggested changes, I am happy to merge. Alternatively, we can iterate on those suggestions if needed.

@willingc willingc requested a review from nedbat June 14, 2025 19:07
@StanFromIreland
Copy link
Member Author

Ah, your suggestions modify the existing wording, which I already have a few patches (& questions) for.

I can commit them for now since they are improvements, and we can iterate further on them in the next prs.

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@willingc willingc merged commit 42e2aee into python:main Jun 15, 2025
4 checks passed
@willingc
Copy link
Collaborator

Thanks @StanFromIreland. I'm looking forward to the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant

2 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant