-
Notifications
You must be signed in to change notification settings - Fork 424
Review toolbar example #539
Copy link
Copy link
Closed
Closed
Copy link
Assignees
Description
Issue body actions
Update as of Dec 3, 2018
The #126 has been redesigned to address the issues listed in the below redesign checklist.
Preview new toolbar in feature branch
The redesigned toolbar in feature branch issue541-toolbar-redesign is ready for review and will be merged to master after issues from this review are resolved.
Toolbar Redesign Checklist
- Issue Toolbar Example: aria-selected should not be used. #540: Toolbar Example: aria-selected should not be used
- Issue Toolbar Example: Use button elements and add other types of elements, such as link and checkbox #541: Toolbar Example: Use button elements and add other types of elements, such as link and checkbox
- Issue Toolbar Example: Bugs with keyboard support, aria-disabled, and aria-label #847: Bugs with keyboard support, aria-disabled, and aria-label
- It's hard to tell the difference between checked and not-checked toggles and radios (Noted by Toolbar example for simple text editor #887).
- Add a title/tooltip to the Bold, Italics, Underline, Align left/center/right, Font type, and size increment/decrement tools (for consistency with Cut/Copy/Paste, and in case any sighted folks need help understanding the icons) (Noted by Toolbar example for simple text editor #887).
- Implement menuitemradio elements as radio elements per issue Need to allow for radiogroup inside toolbar #949.
Metadata
Metadata
Assignees
Relationships
Development
Issue actions