Skip to content

Conversation

@mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 13, 2022

Fixes #2328
Fixes #2378
Tries fixing #2327

Preview Link


WAI Preview Link

@mcking65
Copy link
Contributor Author

@alflennik

In 6d60ae8, I moved the link outside the paragraph, and now the link does not render.

@mcking65 mcking65 changed the title Home Page: Expand ARIA, fix link labels Home Page: Expand ARIA acronym, add APG acronym to h1, fix link labels, fix mailing list link visibility Jun 13, 2022
@alflennik
Copy link
Contributor

Hi @mcking65! Only p tags are supported inside that section. Could you try wrapping the link in a p tag and see if that resolves it?

@mcking65 mcking65 requested review from charmarkk and jongund June 14, 2022 18:26
@mcking65
Copy link
Contributor Author

@alflennik wrote:

Hi @mcking65! Only p tags are supported inside that section. Could you try wrapping the link in a p tag and see if that resolves it?

Thank you Alex! That worked. I hope it looks OK visually.

@mcking65
Copy link
Contributor Author

@charmarkk

I finished the edits we discussed in the meeting. This is ready for review now.

I'd like to know if you think this fully addresses the feedback in #2327.

@richnoah
Copy link
Contributor

@mcking65 from a visual inspection all the requirements have been met.

@charmarkk
Copy link
Contributor

@richnoah - LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home Page: Expand ARIA abbreviation Adjust aria-label on Home page learn more links to start with "Learn more"

5 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant