Skip to content

Conversation

@frozenzia
Copy link
Contributor

@frozenzia frozenzia commented May 24, 2023


WAI Preview Link (Last built on Fri, 09 Jun 2023 20:40:42 GMT).

@howard-e
Copy link
Contributor

This change (cc @a11ydoer

mcking65
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frozenzia, great catch, thank you!!

I used the suggestion feature of the PR to request two changes.

  • change from "which" to "that" because the clause is essential.
  • Add a comma after the independent "for example" clause.

@mcking65 mcking65 changed the title Add missing "which" to correct sentence Hiding Semantics Practice Page: Add missing word "that" Jun 6, 2023
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. documentation Feedback Issue raised by or for collecting input from people outside APG task force Practice Page Related to a page within the practices section of the APG labels Jun 6, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jun 6, 2023
@ccanash
Copy link

ccanash commented Jun 7, 2023

Hi @frozenzia we would like to include this on the upcoming Tuesday release, could you please apply the change that Matt suggested? Thanks!

@frozenzia
Copy link
Contributor Author

@ccanash , I would if I could, but I see

"Merging is blocked -- The base branch restricts merging to authorized users."

Sorry if I'm just being dense, somehow. I'm not very experienced at all in contributing to projects like this, and in the past when I have, the merging has always been handled by the "team in charge". But I'm definitely willing to help if we can just figure out what I should do at this point.

And now I've written all that out it occurs to me that you asked me to "apply the change" that Matt suggested, not do any sort of merging. I'm sorry, but I'm still not seeing where/what I should do.

@frozenzia
Copy link
Contributor Author

@ccanash, had another stab at this after my workday, think I understand now what it was I was supposed to do. "Unresolved" Matt's comment, and that let me then commit the change he suggested. Hope that's all good now.

@mcking65 mcking65 merged commit 08fee22 into w3c:main Jun 9, 2023
@mcking65
Copy link
Contributor

mcking65 commented Jun 9, 2023

Thank you @frozenzia for finding this problem and submitting a fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Practice Page Related to a page within the practices section of the APG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Follow Lee on X/Twitter - Father, Husband, Serial builder creating AI, crypto, games & web tools. We are friends :) AI Will Come To Life!

Check out: eBank.nz (Art Generator) | Netwrck.com (AI Tools) | Text-Generator.io (AI API) | BitBank.nz (Crypto AI) | ReadingTime (Kids Reading) | RewordGame | BigMultiplayerChess | WebFiddle | How.nz | Helix AI Assistant