-
Notifications
You must be signed in to change notification settings - Fork 424
Vertical Temperature Slider Example: Eliminate redundant AX tree rendering of value #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: PR 3258 - Fix slider to remove redundant announcement of value by screen readers<jugglinmike> github: https://github.com//pull/3258 <jugglinmike> This is a fix to https://github.com//issues/3257 <jugglinmike> s/This is/Matt_King: This is/ <jugglinmike> Matt_King: I think it's ready for review. I would love to get it into the next publication <jugglinmike> Matt_King: This is only a modification to the HTML file for slider <jugglinmike> Matt_King: I can push a commit to get rid of the other change that is present right now <jugglinmike> Matt_King: ...or I can ask jongund to do that <jugglinmike> Matt_King: I tested this with JAWS already, actually. I'm happy to do some accessibility review on this <jugglinmike> Matt_King: But I would like to have one other reviewer <jugglinmike> Jem: I know why jongund included that extra change. He fixed the aria-landmark example "resource" page. It should be in a separate pull request, though <jugglinmike> Matt_King: Agreed <jugglinmike> Matt_King: I'll do screen reader testing with JAWS and NVDA <jugglinmike> Matt_King: There are two failing checks in continuous integration <jugglinmike> Matt_King: Is the link checker failing because of that landmarks link? <jugglinmike> howard-e: Testing locally, both versions of that link fail for me <jugglinmike> Matt_King: I think I would probably remove that change. I would even be fine with merging with the failing link and fixing it in a separate pull request <jugglinmike> Jem: Agreed <jugglinmike> Jem: I can review the change to the slider. I will make sure that there are no unexpected changes, like in the visual presentation <jugglinmike> Jem: I don't see any change to the visual presentation <jugglinmike> Matt_King: Maybe this is just a simple 1-minute review <jugglinmike> Matt_King: When I tested with JAWS, it was doing exactly what I was hoping for, which is pretty awesome <jugglinmike> Matt_King: I've added you as a reviewer, Jem |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: PR 3258 - Fix slider to remove redundant announcement of value by screen readers<jugglinmike> github: https://github.com//pull/3258 <jugglinmike> Matt_King: The link checker is failing <jugglinmike> Matt_King: howard-e raised an issue that is related. I didn't add a link here, though <jugglinmike> Matt_King: Can you take your changes out of your pull request, jongund? <jugglinmike> jongund: Sure <jugglinmike> Matt_King: I also wonder if howard-e's existing pull request will address this <jugglinmike> jugglinmike: The error here is due to links with a different domain: tpgi.com <jugglinmike> Matt_King: That's the same destination. The company changed addresses <jugglinmike> Matt_King: howard-e's relevant patch is https://github.com//pull/3264 <jugglinmike> jugglinmike: We can get this reviewed internally and get it merged as part of our maintenance work <jugglinmike> Matt_King: Great! <jugglinmike> Matt_King: If you do that, and jongund makes his change, then pull request 3258 will be almost ready to go <jugglinmike> Matt_King: It's still pending reviews, though <jugglinmike> Matt_King: Jem is listed as reviewer twice on this pull request! <jugglinmike> Matt_King: That's strange <jugglinmike> Matt_King: But I think it's fine that this patch only has one reviewer <jugglinmike> jongund: I've updated the patch as you request <jugglinmike> Matt_King: Awesome. Thank you, jongund <jugglinmike> Matt_King: We're wait on a review of 3264 and then a review from Jem. If we don't hear from Jem next week, we'll touch base next week |
|
@a11ydoer are you able to review? Hoping this good to merge this week in time for publication next week. |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> topic: PR 3258 - Fix slider to remove redundant announcement of value by screen readers<jugglinmike> github: https://github.com//pull/3258 <jugglinmike> Matt_King: For the link checker fix, it looked like it was reviewed and approved, but I didn't merge it. <jugglinmike> howard-e: I merged it this morning <jugglinmike> Matt_King: It sounded like maybe that solution is a little brittle <jugglinmike> howard-e: Yes <jugglinmike> Matt_King: I still don't understand why the user-agent matters <jugglinmike> howard-e: Some websites reject traffic from browsers that present themselves as a certain version--often due to compatibility concerns <jugglinmike> Matt_King: If we re-run these tests, should it pass, now? <jugglinmike> howard-e: Yes, it should <jugglinmike> Matt_King: I tested this with two screen readers <jugglinmike> howard-e: We need to merge from the "main" branch, first <jugglinmike> Matt_King: Oh, yes! I will do that |
Merge branch 'main' into update/vertical-slider
mcking65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, many thanks @jongund!
Resolves #3257
Changes the vertical temperature slider to eliminate redundant announcement of the slider value by screen readers. This change makes the value displayed visually above the slider a child of the slider so its content becomes presentational.
Vertical Slider Preview
WAI Preview Link (Last built on Mon, 26 May 2025 02:02:22 GMT).