-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve wording for braille patterns #1287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current working is confusing, Part of specification says " not contain any characters in Unicode Braille Patterns ". Is there a reason we are not using "must not" or "should not"?
It seems clearer to say:
"The value of aria-braillelabel must (or should) not contain any Unicode Braille characters or values that result in no dots being rendered (e.g. Braille Pattern dots-0).
Then later it says the Braille should be translated by the assistive technology if not a Unicode Braille Pattern, So two things here, in general we have not been giving any direction to assistive technology developers and it would seem to be obvious to them not to translate the Unicode Braille characters if they found them.
@jongund wrote:
It is a SHOULD (not) - the list is preceded by "authors SHOULD also ensure that". This matches the way aria-label and aria-roledescription talk about these things.
The current version took a lot of iterations to arrive at. Personally, I'd suggest to keep it as is.
The current version reflects feedback from AT developers. |
Thanks @jongund! (For what it's worth, I think there's a good chance we'll see another iteration before 1.3 is finalized, e.g., implementation feedback.) |
Also thanks @sinabahram! |
Resolves #1232
Depends on w3c/aria-common#45
Diff