-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-braille properties: improve authoring note #1291
Conversation
Adds clarifying language to the note for aria-braillelabel and aria-roledescription to help authors understand what they need to consider when using these properties.
To simplify the diffing: Current version:
Proposed version
(And the same change for aria-brailleRoleDescription.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks, @pkra !
I have some concerns over description or details being recommended, even as just an example, here. Will that not cause tons of unnecessary speech? Even something as short as "has braille" would be repeated per element? I like the reference to documentation, but I hesitate to call out description or details. Thoughts? |
@sinabahram wrote
Right. In #1205 (comment) I had suggested a description for a one-off button use case. But it's probably too risky to write it this way here, i.e., developers might stop reading and use a description. @carmacleod since I blatantly copied your suggestion from that thread, what do you think? I'll think about other use cases that might be less problematic but I'd also be ok if the note only mentions (product) documentation as an example. Complex examples could still be done elsewhere. |
for what it's worth, I vote to remove both description and details |
I agree that without the "one off" context, we shouldn't mention details or description. So it's perfectly ok with me to have the note only mention product documentation. Thanks for pointing this out, @sinabahram ! |
remove references to description or details as example.
I've pushed a change to strip it down to: "For example, this could be done in the product documentation." |
Awesome, approved on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with or without, but consider added a note near the localization comment that braille users use different braille tables that don't always align with a language, so using literal braille characters should be avoided unless there is no other option.
@cookiecrook wrote:
Just to double check here's how the note currently starts:
and ends with
So the suggestion would be to add something to the sentences in between, correct? (I'm happy to add more, I'm just not sure how to do it well.) |
I've added a manual note to the Braille project board https://github.com/w3c/aria/projects/9#card-40750290 so this is ready to merge. |
Please go ahead and merge. We can always update later if a good idea presents itself. Thanks! |
Musing ideas for later... There could be tips on this in the APG... Things like, avoid capital letters and unnecessary punctuation in |
True, but doesn't 8-dot settings for conveying caps take care of that particular concern? I want to be careful about content folks blanket-interpreting this to mean remove useful info and flatten Braille, which is totally not the intent, but may be an inadvertent result. Just something to keep in mind while coming up with these. |
Adds clarifying language to the note for aria-braillelabel and
aria-brailleroledescription to help authors understand what they need
to consider when using these properties.
Closes #1205